From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55679) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0cnX-0001WK-CW for qemu-devel@nongnu.org; Wed, 11 May 2016 18:40:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0cnR-0000X1-75 for qemu-devel@nongnu.org; Wed, 11 May 2016 18:40:06 -0400 From: Eric Blake Date: Wed, 11 May 2016 16:39:43 -0600 Message-Id: <1463006384-7734-11-git-send-email-eblake@redhat.com> In-Reply-To: <1463006384-7734-1-git-send-email-eblake@redhat.com> References: <1463006384-7734-1-git-send-email-eblake@redhat.com> Subject: [Qemu-devel] [PATCH v4 10/11] nbd: Detect servers that send unexpected error values List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: qemu-block@nongnu.org, pbonzini@redhat.com, alex@alex.org.uk Add some debugging to flag servers that are not compliant to the NBD protocol. This would have flagged the server bug fixed in commit c0301fcc. Signed-off-by: Eric Blake Reviewed-by: Alex Bligh --- v3: later in series, but no change --- nbd/client.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/nbd/client.c b/nbd/client.c index 937344c..4659df3 100644 --- a/nbd/client.c +++ b/nbd/client.c @@ -33,8 +33,10 @@ static int nbd_errno_to_system_errno(int err) return ENOMEM; case NBD_ENOSPC: return ENOSPC; + default: + TRACE("Squashing unexpected error %d to EINVAL", err); + /* fallthrough */ case NBD_EINVAL: - default: return EINVAL; } } -- 2.5.5