From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:39737)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b0r26-0007pt-W6
	for qemu-devel@nongnu.org; Thu, 12 May 2016 09:52:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b0r23-0000cg-Ib
	for qemu-devel@nongnu.org; Thu, 12 May 2016 09:52:06 -0400
Received: from mx1.redhat.com ([209.132.183.28]:52224)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b0r23-0000cc-D3
	for qemu-devel@nongnu.org; Thu, 12 May 2016 09:52:03 -0400
Message-ID: <1463061120.14756.1.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Thu, 12 May 2016 15:52:00 +0200
In-Reply-To: <1463032067-20434-1-git-send-email-jgross@suse.com>
References: <1463032067-20434-1-git-send-email-jgross@suse.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v4 0/3] usb, xen: add pvUSB backend
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Juergen Gross <jgross@suse.com>
Cc: qemu-devel@nongnu.org, xen-devel@lists.xensource.com, stefano.stabellini@eu.citrix.com, konrad.wilk@oracle.com, anthony.perard@citrix.com

On Do, 2016-05-12 at 07:47 +0200, Juergen Gross wrote:
> This series adds a Xen pvUSB backend driver to qemu. USB devices
> connected to the host can be passed through to a Xen guest. The
> devices are specified via Xenstore. Access to the devices is done
> via host-libusb.c
>=20
> I've tested the backend with various USB devices (memory sticks,
> keyboard, ...).

Doesn't pass scripts/checkpatch.pl:

Applying: xen: write information about supported backends
=3D=3D=3D checkpatch complains =3D=3D=3D
WARNING: line over 80 characters
#14: FILE: hw/xen/xen_backend.c:49:
+static QTAILQ_HEAD(xs_dirs_head, xs_dirs) xs_cleanup =3D
QTAILQ_HEAD_INITIALIZER(xs_cleanup);

ERROR: space required after that close brace '}'
#53: FILE: hw/xen/xen_backend.c:109:
+        }};

WARNING: space prohibited between function name and open parenthesis '('
#85: FILE: hw/xen/xen_backend.c:785:
+    snprintf(path, sizeof (path), "device-model/%u/backends/%s",
xen_domid,

total: 1 errors, 2 warnings, 161 lines checked

cheers,
  Gerd