From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40514) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0r74-0006hM-Sg for qemu-devel@nongnu.org; Thu, 12 May 2016 09:57:19 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b0r70-0001Po-6T for qemu-devel@nongnu.org; Thu, 12 May 2016 09:57:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40737) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b0r70-0001Pk-1E for qemu-devel@nongnu.org; Thu, 12 May 2016 09:57:10 -0400 Message-ID: <1463061427.14756.5.camel@redhat.com> From: Gerd Hoffmann Date: Thu, 12 May 2016 15:57:07 +0200 In-Reply-To: References: <1462859517-30207-1-git-send-email-kraxel@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PULL 00/12] ui patch queue List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: QEMU Developers > Commiserations on the first failed-to-build pullreq of the 2.7 cycle: >=20 > /home/pm215/qemu/ui/gtk.c: In function =E2=80=98gd_menu_copy=E2=80=99: > /home/pm215/qemu/ui/gtk.c:1270:21: error: unused variable =E2=80=98vc=E2= =80=99 > [-Werror=3Dunused-variable] > VirtualConsole *vc =3D gd_vc_find_current(s); > ^ >=20 > This was on ppc64be Linux, though I'm guessing that's just because > it's the only system that happens not to define CONFIG_VTE. mingw builds don't have vte too, so I'm wondering now how that one managed to escape my attention ... > (Q: should we even put the "Copy" entry into the menu if we can't > actually support copying text ?) I was trying to not clutter up the patch with too many #ifdef CONFIG_VTE. But, yes, probably we should just #ifdef the whole function and and not add the menu entry. cheers, Gerd