qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Eduardo Habkost <ehabkost@redhat.com>
To: qemu-devel@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>
Cc: Markus Armbruster <armbru@redhat.com>
Subject: [Qemu-devel] [PATCH 4/6] main-loop: Use &error_fatal when calling qemu_init_main_loop()
Date: Thu, 12 May 2016 11:10:02 -0300	[thread overview]
Message-ID: <1463062204-20330-5-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1463062204-20330-1-git-send-email-ehabkost@redhat.com>

Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
 qemu-img.c | 5 +----
 qemu-io.c  | 5 +----
 qemu-nbd.c | 5 +----
 vl.c       | 6 +-----
 4 files changed, 4 insertions(+), 17 deletions(-)

diff --git a/qemu-img.c b/qemu-img.c
index 46f2a6d..d3cfec3 100644
--- a/qemu-img.c
+++ b/qemu-img.c
@@ -3465,10 +3465,7 @@ int main(int argc, char **argv)
     error_set_progname(argv[0]);
     qemu_init_exec_dir(argv[0]);
 
-    if (qemu_init_main_loop(&local_error)) {
-        error_report_err(local_error);
-        exit(EXIT_FAILURE);
-    }
+    qemu_init_main_loop(&error_fatal);
 
     if (qcrypto_init(&local_error) < 0) {
         error_reportf_err(local_error, "cannot initialize crypto: ");
diff --git a/qemu-io.c b/qemu-io.c
index 0598251..1507559 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -527,10 +527,7 @@ int main(int argc, char **argv)
         exit(1);
     }
 
-    if (qemu_init_main_loop(&local_error)) {
-        error_report_err(local_error);
-        exit(1);
-    }
+    qemu_init_main_loop(&error_fatal);
 
     if (qemu_opts_foreach(&qemu_object_opts,
                           user_creatable_add_opts_foreach,
diff --git a/qemu-nbd.c b/qemu-nbd.c
index c55b40f..f2685e67 100644
--- a/qemu-nbd.c
+++ b/qemu-nbd.c
@@ -820,10 +820,7 @@ int main(int argc, char **argv)
 
     saddr = nbd_build_socket_address(sockpath, bindto, port);
 
-    if (qemu_init_main_loop(&local_err)) {
-        error_report_err(local_err);
-        exit(EXIT_FAILURE);
-    }
+    qemu_init_main_loop(&error_fatal);
     bdrv_init();
     atexit(bdrv_close_all);
 
diff --git a/vl.c b/vl.c
index eea8a04..e435926 100644
--- a/vl.c
+++ b/vl.c
@@ -2964,7 +2964,6 @@ int main(int argc, char **argv, char **envp)
     ram_addr_t maxram_size;
     uint64_t ram_slots = 0;
     FILE *vmstate_dump_file = NULL;
-    Error *main_loop_err = NULL;
     Error *err = NULL;
 
     qemu_init_cpu_loop();
@@ -4001,10 +4000,7 @@ int main(int argc, char **argv, char **envp)
 
     os_daemonize();
 
-    if (qemu_init_main_loop(&main_loop_err)) {
-        error_report_err(main_loop_err);
-        exit(1);
-    }
+    qemu_init_main_loop(&error_fatal);
 
     if (qemu_opts_foreach(qemu_find_opts("sandbox"),
                           parse_sandbox, NULL, NULL)) {
-- 
2.5.5

  parent reply	other threads:[~2016-05-12 14:10 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-12 14:09 [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization code Eduardo Habkost
2016-05-12 14:09 ` [Qemu-devel] [PATCH 1/6] vl: Use &error_fatal when parsing VNC options Eduardo Habkost
2016-05-12 14:10 ` [Qemu-devel] [PATCH 2/6] vl: Use &error_fatal when parsing monitor options Eduardo Habkost
2016-05-12 14:10 ` [Qemu-devel] [PATCH 3/6] main-loop: Use Error** to report qemu_signal_init() errors Eduardo Habkost
2016-05-12 14:10 ` Eduardo Habkost [this message]
2016-05-12 14:10 ` [Qemu-devel] [PATCH 5/6] main-loop: Make qemu_init_main_loop() and qemu_signal_init() void Eduardo Habkost
2016-05-12 14:10 ` [Qemu-devel] [PATCH 6/6] Use &error_fatal when initializing crypto on qemu-{img, io, nbd} Eduardo Habkost
2016-05-12 16:48 ` [Qemu-devel] [PATCH 0/6] Use &error_fatal in some initialization code Paolo Bonzini
2016-05-12 17:04   ` Eduardo Habkost
2016-05-16 14:25     ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463062204-20330-5-git-send-email-ehabkost@redhat.com \
    --to=ehabkost@redhat.com \
    --cc=armbru@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).