From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org,
Timothy Edward Baldwin <T.E.Baldwin99@members.leeds.ac.uk>,
Riku Voipio <riku.voipio@iki.fi>,
Richard Henderson <rth@twiddle.net>
Subject: [Qemu-devel] [PATCH v2 17/28] linux-user: Support for restarting system calls for CRIS targets
Date: Thu, 12 May 2016 18:47:41 +0100 [thread overview]
Message-ID: <1463075272-9933-18-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1463075272-9933-1-git-send-email-peter.maydell@linaro.org>
From: Timothy E Baldwin <T.E.Baldwin99@members.leeds.ac.uk>
Update the CRIS main loop and sigreturn code:
* on TARGET_ERESTARTSYS, wind guest PC backwards to repeat syscall insn
* set all guest CPU state within signal.c code on sigreturn
* handle TARGET_QEMU_ESIGRETURN in the main loop as the indication
that the main loop should not touch any guest CPU state
Signed-off-by: Timothy Edward Baldwin <T.E.Baldwin99@members.leeds.ac.uk>
Message-id: 1441497448-32489-34-git-send-email-T.E.Baldwin99@members.leeds.ac.uk
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Edgar E. Iglesias <edgar.iglesias@xilinx.com>
[PMM: tweak commit message; drop TARGET_USE_ERESTARTSYS define]
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
linux-user/cris/target_signal.h | 1 +
linux-user/main.c | 6 +++++-
linux-user/signal.c | 2 +-
3 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/linux-user/cris/target_signal.h b/linux-user/cris/target_signal.h
index 5611840..e0f1382 100644
--- a/linux-user/cris/target_signal.h
+++ b/linux-user/cris/target_signal.h
@@ -26,4 +26,5 @@ static inline abi_ulong get_sp_from_cpustate(CPUCRISState *state)
return state->regs[14];
}
+
#endif /* TARGET_SIGNAL_H */
diff --git a/linux-user/main.c b/linux-user/main.c
index 4710e97..2df4e27 100644
--- a/linux-user/main.c
+++ b/linux-user/main.c
@@ -2913,7 +2913,11 @@ void cpu_loop(CPUCRISState *env)
env->pregs[7],
env->pregs[11],
0, 0);
- env->regs[10] = ret;
+ if (ret == -TARGET_ERESTARTSYS) {
+ env->pc -= 2;
+ } else if (ret != -TARGET_QEMU_ESIGRETURN) {
+ env->regs[10] = ret;
+ }
break;
case EXCP_DEBUG:
{
diff --git a/linux-user/signal.c b/linux-user/signal.c
index 51e11c1..71a8e2a 100644
--- a/linux-user/signal.c
+++ b/linux-user/signal.c
@@ -3785,7 +3785,7 @@ long do_sigreturn(CPUCRISState *env)
restore_sigcontext(&frame->sc, env);
unlock_user_struct(frame, frame_addr, 0);
- return env->regs[10];
+ return -TARGET_QEMU_ESIGRETURN;
badframe:
force_sig(TARGET_SIGSEGV);
}
--
1.9.1
next prev parent reply other threads:[~2016-05-12 17:48 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-12 17:47 [Qemu-devel] [PATCH v2 00/28] linux-user: fix race between signals and syscalls Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 01/28] linux-user: Check array bounds in errno conversion Peter Maydell
2016-05-23 23:54 ` Laurent Vivier
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 02/28] linux-user: Consistently return host errnos from do_openat() Peter Maydell
2016-05-24 0:05 ` Laurent Vivier
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 03/28] linux-user: Reindent signal handling Peter Maydell
2016-05-24 0:21 ` Laurent Vivier
2016-05-24 6:47 ` Riku Voipio
2016-05-24 7:31 ` Laurent Vivier
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 04/28] linux-user: Define TARGET_ERESTART* errno values Peter Maydell
2016-05-24 9:42 ` Laurent Vivier
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 05/28] linux-user: Renumber TARGET_QEMU_ESIGRETURN, make it not arch-specific Peter Maydell
2016-05-24 0:29 ` Laurent Vivier
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 06/28] linux-user: Support for restarting system calls for x86 targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 07/28] linux-user: Support for restarting system calls for ARM targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 08/28] linux-user: Support for restarting system calls for MIPS targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 09/28] linux-user: Support for restarting system calls for PPC targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 10/28] linux-user: Support for restarting system calls for SPARC targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 11/28] linux-user: Support for restarting system calls for SH4 targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 12/28] linux-user: Support for restarting system calls for Alpha targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 13/28] linux-user: Support for restarting system calls for UniCore32 targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 14/28] linux-user: Support for restarting system calls for OpenRISC targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 15/28] linux-user: Support for restarting system calls for M68K targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 16/28] linux-user: Support for restarting system calls for S390 targets Peter Maydell
2016-05-12 17:47 ` Peter Maydell [this message]
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 18/28] linux-user: Support for restarting system calls for tilegx targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 19/28] linux-user: Set r14 on exit from microblaze syscall Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 20/28] linux-user: Support for restarting system calls for Microblaze targets Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 21/28] linux-user: Add debug code to exercise restarting system calls Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 22/28] linux-user: Provide safe_syscall for fixing races between signals and syscalls Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 23/28] linux-user: Use safe_syscall for read and write system calls Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 24/28] linux-user: Use safe_syscall for open and openat " Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 25/28] linux-user: Use safe_syscall for wait " Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 26/28] linux-user: Use safe_syscall for execve syscall Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 27/28] linux-user: Use safe_syscall for pselect, select syscalls Peter Maydell
2016-05-12 17:47 ` [Qemu-devel] [PATCH v2 28/28] linux-user: Use safe_syscall for futex syscall Peter Maydell
2016-05-23 18:55 ` [Qemu-devel] [PATCH v2 00/28] linux-user: fix race between signals and syscalls Peter Maydell
2016-05-24 8:04 ` Riku Voipio
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463075272-9933-18-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=T.E.Baldwin99@members.leeds.ac.uk \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).