From: "Denis V. Lunev" <den@openvz.org>
To: qemu-devel@nongnu.org
Cc: den@openvz.org, Kevin Wolf <kwolf@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io
Date: Sat, 14 May 2016 15:01:08 +0300 [thread overview]
Message-ID: <1463227273-27523-2-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1463227273-27523-1-git-send-email-den@openvz.org>
It would be convinient to enable tracepoints in qemu-io binary. This would
allow to perform investigations without additional code recompilations.
The command line will be exactly the same as in qemu-system.
Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Kevin Wolf <kwolf@redhat.com>
CC: Paolo Bonzini <pbonzini@redhat.com>
---
qemu-io.c | 43 +++++++++++++++++++++++++++++++++++++++++++
1 file changed, 43 insertions(+)
diff --git a/qemu-io.c b/qemu-io.c
index 5ef3ef7..2d0d2b0 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -18,6 +18,7 @@
#include "qemu/option.h"
#include "qemu/config-file.h"
#include "qemu/readline.h"
+#include "qemu/log.h"
#include "qapi/qmp/qstring.h"
#include "qom/object_interfaces.h"
#include "sysemu/block-backend.h"
@@ -419,6 +420,25 @@ static QemuOptsList qemu_object_opts = {
},
};
+static QemuOptsList qemu_trace_opts = {
+ .name = "trace",
+ .implied_opt_name = "enable",
+ .head = QTAILQ_HEAD_INITIALIZER(qemu_trace_opts.head),
+ .desc = {
+ {
+ .name = "enable",
+ .type = QEMU_OPT_STRING,
+ },
+ {
+ .name = "events",
+ .type = QEMU_OPT_STRING,
+ },{
+ .name = "file",
+ .type = QEMU_OPT_STRING,
+ },
+ { /* end of list */ }
+ },
+};
static QemuOptsList file_opts = {
.name = "file",
@@ -473,6 +493,7 @@ int main(int argc, char **argv)
module_call_init(MODULE_INIT_QOM);
qemu_add_opts(&qemu_object_opts);
+ qemu_add_opts(&qemu_trace_opts);
bdrv_init();
while ((c = getopt_long(argc, argv, sopt, lopt, &opt_index)) != -1) {
@@ -512,10 +533,32 @@ int main(int argc, char **argv)
}
break;
case 'T':
+ {
+ QemuOpts *trace_opts;
+ char *trace_file;
+
+ trace_opts = qemu_opts_parse_noisily(qemu_find_opts("trace"),
+ optarg, true);
+ if (trace_opts == NULL) {
+ exit(1);
+ }
+ if (qemu_opt_get(trace_opts, "enable")) {
+ trace_enable_events(qemu_opt_get(trace_opts, "enable"));
+ }
+ trace_init_events(qemu_opt_get(trace_opts, "events"));
+
+ trace_file = g_strdup(qemu_opt_get(trace_opts, "file"));
+ qemu_opts_del(trace_opts);
+
if (!trace_init_backends()) {
exit(1); /* error message will have been printed */
}
+ trace_init_file(trace_file);
+ g_free(trace_file);
+
+ qemu_set_log(LOG_TRACE);
break;
+ }
case 'V':
printf("%s version %s\n", progname, QEMU_VERSION);
exit(0);
--
2.5.0
next prev parent reply other threads:[~2016-05-14 12:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-14 12:01 [Qemu-devel] [PATCH 0/6] qcow2_co_write_zeroes and related improvements Denis V. Lunev
2016-05-14 12:01 ` Denis V. Lunev [this message]
2016-05-16 13:09 ` [Qemu-devel] [PATCH 1/6] qemu-io: enable tracing in qemu-io Paolo Bonzini
2016-05-16 13:21 ` Denis V. Lunev
2016-05-16 16:07 ` Eric Blake
2016-05-14 12:01 ` [Qemu-devel] [PATCH 2/6] block: split write_zeroes always Denis V. Lunev
2016-05-16 16:13 ` Eric Blake
2016-05-14 12:01 ` [Qemu-devel] [PATCH 3/6] qcow2: simplify logic in qcow2_co_write_zeroes Denis V. Lunev
2016-05-16 16:28 ` Eric Blake
2016-05-14 12:01 ` [Qemu-devel] [PATCH 4/6] qcow2: add tracepoints for qcow2_co_write_zeroes Denis V. Lunev
2016-05-16 16:32 ` Eric Blake
2016-05-16 16:48 ` Denis V. Lunev
2016-05-14 12:01 ` [Qemu-devel] [PATCH 5/6] qcow2: fix condition in is_zero_cluster Denis V. Lunev
2016-05-14 12:01 ` [Qemu-devel] [PATCH 6/6] qcow2: merge is_zero_cluster helpers into qcow2_co_write_zeroes Denis V. Lunev
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463227273-27523-2-git-send-email-den@openvz.org \
--to=den@openvz.org \
--cc=kwolf@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).