qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: "Denis V. Lunev" <den@openvz.org>
To: qemu-devel@nongnu.org
Cc: den@openvz.org, Paolo Bonzini <pbonzini@redhat.com>,
	Stefan Hajnoczi <stefanha@redhat.com>,
	Kevin Wolf <kwolf@redhat.com>
Subject: [Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io
Date: Tue, 17 May 2016 11:20:30 +0300	[thread overview]
Message-ID: <1463473231-491-3-git-send-email-den@openvz.org> (raw)
In-Reply-To: <1463473231-491-1-git-send-email-den@openvz.org>

Moving trace_init_backends() into trace_opt_parse() is not possible. This
should be called after daemonize() in vl.c.

Signed-off-by: Denis V. Lunev <den@openvz.org>
CC: Paolo Bonzini <pbonzini@redhat.com>
CC: Stefan Hajnoczi <stefanha@redhat.com>
CC: Kevin Wolf <kwolf@redhat.com>
---
 qemu-io.c | 13 ++++++++++---
 1 file changed, 10 insertions(+), 3 deletions(-)

diff --git a/qemu-io.c b/qemu-io.c
index 5ef3ef7..1910fe3 100644
--- a/qemu-io.c
+++ b/qemu-io.c
@@ -18,6 +18,7 @@
 #include "qemu/option.h"
 #include "qemu/config-file.h"
 #include "qemu/readline.h"
+#include "qemu/log.h"
 #include "qapi/qmp/qstring.h"
 #include "qom/object_interfaces.h"
 #include "sysemu/block-backend.h"
@@ -458,6 +459,7 @@ int main(int argc, char **argv)
     Error *local_error = NULL;
     QDict *opts = NULL;
     const char *format = NULL;
+    char *trace_file = NULL;
 
 #ifdef CONFIG_POSIX
     signal(SIGPIPE, SIG_IGN);
@@ -473,6 +475,7 @@ int main(int argc, char **argv)
 
     module_call_init(MODULE_INIT_QOM);
     qemu_add_opts(&qemu_object_opts);
+    qemu_add_opts(&qemu_trace_opts);
     bdrv_init();
 
     while ((c = getopt_long(argc, argv, sopt, lopt, &opt_index)) != -1) {
@@ -512,9 +515,7 @@ int main(int argc, char **argv)
             }
             break;
         case 'T':
-            if (!trace_init_backends()) {
-                exit(1); /* error message will have been printed */
-            }
+            trace_file = trace_opt_parse(optarg, trace_file);
             break;
         case 'V':
             printf("%s version %s\n", progname, QEMU_VERSION);
@@ -560,6 +561,12 @@ int main(int argc, char **argv)
         exit(1);
     }
 
+    if (!trace_init_backends()) {
+        exit(1);
+    }
+    trace_init_file(trace_file);
+    qemu_set_log(LOG_TRACE);
+
     /* initialize commands */
     qemuio_add_command(&quit_cmd);
     qemuio_add_command(&open_cmd);
-- 
2.1.4

  parent reply	other threads:[~2016-05-17  8:21 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-17  8:20 [Qemu-devel] [PATCH 0/3] trace: enable tracing in qemu-io/qemu-nbd Denis V. Lunev
2016-05-17  8:20 ` [Qemu-devel] [PATCH 1/3] trace: move qemu_trace_opts to trace/control.c Denis V. Lunev
2016-05-19 23:15   ` Eric Blake
2016-05-17  8:20 ` Denis V. Lunev [this message]
2016-05-19 23:23   ` [Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io Eric Blake
2016-05-17  8:20 ` [Qemu-devel] [PATCH 3/3] trace: enable tracing in qemu-nbd Denis V. Lunev
2016-05-19 23:26   ` Eric Blake
2016-05-31  8:50     ` Denis V. Lunev
2016-05-17 12:40 ` [Qemu-devel] [PATCH 0/3] trace: enable tracing in qemu-io/qemu-nbd Paolo Bonzini
2016-05-27 20:39 ` Stefan Hajnoczi
2016-05-27 20:42   ` Denis V. Lunev
  -- strict thread matches above, loose matches on Subject: below --
2016-05-31  8:58 [Qemu-devel] [PATCH v2 " Denis V. Lunev
2016-05-31  8:58 ` [Qemu-devel] [PATCH 2/3] trace: enable tracing in qemu-io Denis V. Lunev
2016-05-31 17:55   ` Eric Blake

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463473231-491-3-git-send-email-den@openvz.org \
    --to=den@openvz.org \
    --cc=kwolf@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).