From: "Wei, Jiangang" <weijg.fnst@cn.fujitsu.com>
To: "qemu-devel@nongnu.org" <qemu-devel@nongnu.org>
Cc: "stefanha@redhat.com" <stefanha@redhat.com>,
"kraxel@redhat.com" <kraxel@redhat.com>,
"berrange@redhat.com" <berrange@redhat.com>,
"pbonzini@redhat.com" <pbonzini@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] configure: fix error messages
Date: Tue, 17 May 2016 10:20:06 +0000 [thread overview]
Message-ID: <1463480372.2090.37.camel@localhost> (raw)
In-Reply-To: <1462875216-10813-1-git-send-email-weijg.fnst@cn.fujitsu.com>
ping ...
Any comments?
On Tue, 2016-05-10 at 18:13 +0800, Wei Jiangang wrote:
> spice-server-devel is required, not spice-protocol-devel.
> "spice-protocol(>=0.12.3) devel" maybe mislead user.
>
> when configure isn't able to find the required usb-redir,
> It's better to explicitly output version requirement.
>
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index c37fc5f..0190fb7 100755
> --- a/configure
> +++ b/configure
> @@ -3974,7 +3974,7 @@ EOF
> else
> if test "$spice" = "yes" ; then
> feature_not_found "spice" \
> - "Install spice-server(>=0.12.0) and spice-protocol(>=0.12.3) devel"
> + "Install spice-server(>=0.12.0) devel and spice-protocol(>=0.12.3)"
> fi
> spice="no"
> fi
> @@ -4023,7 +4023,7 @@ if test "$usb_redir" != "no" ; then
> libs_softmmu="$libs_softmmu $usb_redir_libs"
> else
> if test "$usb_redir" = "yes"; then
> - feature_not_found "usb-redir" "Install usbredir devel"
> + feature_not_found "usb-redir" "Install usbredir devel(>=0.6)"
> fi
> usb_redir="no"
> fi
prev parent reply other threads:[~2016-05-17 10:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-10 10:13 [Qemu-devel] [PATCH] configure: fix error messages Wei Jiangang
2016-05-17 10:20 ` Wei, Jiangang [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463480372.2090.37.camel@localhost \
--to=weijg.fnst@cn.fujitsu.com \
--cc=berrange@redhat.com \
--cc=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).