* [Qemu-devel] [PATCH] configure: fix error messages
@ 2016-05-10 10:13 Wei Jiangang
2016-05-17 10:20 ` Wei, Jiangang
0 siblings, 1 reply; 2+ messages in thread
From: Wei Jiangang @ 2016-05-10 10:13 UTC (permalink / raw)
To: qemu-devel; +Cc: berrange, pbonzini, stefanha, kraxel, Wei Jiangang
spice-server-devel is required, not spice-protocol-devel.
"spice-protocol(>=0.12.3) devel" maybe mislead user.
when configure isn't able to find the required usb-redir,
It's better to explicitly output version requirement.
Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
---
configure | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/configure b/configure
index c37fc5f..0190fb7 100755
--- a/configure
+++ b/configure
@@ -3974,7 +3974,7 @@ EOF
else
if test "$spice" = "yes" ; then
feature_not_found "spice" \
- "Install spice-server(>=0.12.0) and spice-protocol(>=0.12.3) devel"
+ "Install spice-server(>=0.12.0) devel and spice-protocol(>=0.12.3)"
fi
spice="no"
fi
@@ -4023,7 +4023,7 @@ if test "$usb_redir" != "no" ; then
libs_softmmu="$libs_softmmu $usb_redir_libs"
else
if test "$usb_redir" = "yes"; then
- feature_not_found "usb-redir" "Install usbredir devel"
+ feature_not_found "usb-redir" "Install usbredir devel(>=0.6)"
fi
usb_redir="no"
fi
--
1.9.3
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [Qemu-devel] [PATCH] configure: fix error messages
2016-05-10 10:13 [Qemu-devel] [PATCH] configure: fix error messages Wei Jiangang
@ 2016-05-17 10:20 ` Wei, Jiangang
0 siblings, 0 replies; 2+ messages in thread
From: Wei, Jiangang @ 2016-05-17 10:20 UTC (permalink / raw)
To: qemu-devel@nongnu.org
Cc: stefanha@redhat.com, kraxel@redhat.com, berrange@redhat.com,
pbonzini@redhat.com
ping ...
Any comments?
On Tue, 2016-05-10 at 18:13 +0800, Wei Jiangang wrote:
> spice-server-devel is required, not spice-protocol-devel.
> "spice-protocol(>=0.12.3) devel" maybe mislead user.
>
> when configure isn't able to find the required usb-redir,
> It's better to explicitly output version requirement.
>
> Signed-off-by: Wei Jiangang <weijg.fnst@cn.fujitsu.com>
> ---
> configure | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/configure b/configure
> index c37fc5f..0190fb7 100755
> --- a/configure
> +++ b/configure
> @@ -3974,7 +3974,7 @@ EOF
> else
> if test "$spice" = "yes" ; then
> feature_not_found "spice" \
> - "Install spice-server(>=0.12.0) and spice-protocol(>=0.12.3) devel"
> + "Install spice-server(>=0.12.0) devel and spice-protocol(>=0.12.3)"
> fi
> spice="no"
> fi
> @@ -4023,7 +4023,7 @@ if test "$usb_redir" != "no" ; then
> libs_softmmu="$libs_softmmu $usb_redir_libs"
> else
> if test "$usb_redir" = "yes"; then
> - feature_not_found "usb-redir" "Install usbredir devel"
> + feature_not_found "usb-redir" "Install usbredir devel(>=0.6)"
> fi
> usb_redir="no"
> fi
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-05-17 10:20 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-10 10:13 [Qemu-devel] [PATCH] configure: fix error messages Wei Jiangang
2016-05-17 10:20 ` Wei, Jiangang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).