From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:57201) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2eXc-0003gF-Pl for qemu-devel@nongnu.org; Tue, 17 May 2016 08:56:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2eXX-0005Jc-O6 for qemu-devel@nongnu.org; Tue, 17 May 2016 08:56:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:42041) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2eXX-0005JY-IJ for qemu-devel@nongnu.org; Tue, 17 May 2016 08:55:59 -0400 From: "Dr. David Alan Gilbert (git)" Date: Tue, 17 May 2016 13:55:50 +0100 Message-Id: <1463489755-30703-2-git-send-email-dgilbert@redhat.com> In-Reply-To: <1463489755-30703-1-git-send-email-dgilbert@redhat.com> References: <1463489755-30703-1-git-send-email-dgilbert@redhat.com> Subject: [Qemu-devel] [PATCH v4 1/6] Postcopy: Avoid 0 length discards List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, quintela@redhat.com, amit.shah@redhat.com Cc: aarcange@redhat.com, den@openvz.org, marcel.a@redhat.com From: "Dr. David Alan Gilbert" The discard code in migration/ram.c would send request for zero length discards in the case where no discards were needed. It doesn't appear to have had any bad effect. Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Denis V. Lunev --- migration/ram.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/migration/ram.c b/migration/ram.c index 3f05738..e96c2af 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -1557,7 +1557,9 @@ static int postcopy_send_discard_bm_ram(MigrationState *ms, } else { discard_length = zero - one; } - postcopy_discard_send_range(ms, pds, one, discard_length); + if (discard_length) { + postcopy_discard_send_range(ms, pds, one, discard_length); + } current = one + discard_length; } else { current = one; -- 2.5.5