From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55419) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b2gC1-0004Gk-OJ for qemu-devel@nongnu.org; Tue, 17 May 2016 10:41:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b2gC0-0005j7-LN for qemu-devel@nongnu.org; Tue, 17 May 2016 10:41:53 -0400 From: Max Reitz Date: Tue, 17 May 2016 16:41:26 +0200 Message-Id: <1463496094-21608-2-git-send-email-mreitz@redhat.com> In-Reply-To: <1463496094-21608-1-git-send-email-mreitz@redhat.com> References: <1463496094-21608-1-git-send-email-mreitz@redhat.com> Subject: [Qemu-devel] [PATCH v4 1/9] block: Drop useless bdrv_new() call List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, Max Reitz , Kevin Wolf , Alberto Garcia bdrv_append_temp_snapshot() uses bdrv_new() to create an empty BDS before invoking bdrv_open() on that BDS. This is probably a relict from when it used to do some modifications on that empty BDS, but now that is unnecessary, so we can just set bs_snapshot to NULL and let bdrv_open() do the rest. Signed-off-by: Max Reitz Reviewed-by: Alberto Garcia Reviewed-by: Kevin Wolf --- block.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block.c b/block.c index cbc10f7..d2ecf93 100644 --- a/block.c +++ b/block.c @@ -1470,8 +1470,7 @@ static int bdrv_append_temp_snapshot(BlockDriverState *bs, int flags, qdict_put(snapshot_options, "driver", qstring_from_str("qcow2")); - bs_snapshot = bdrv_new(); - + bs_snapshot = NULL; ret = bdrv_open(&bs_snapshot, NULL, NULL, snapshot_options, flags, &local_err); snapshot_options = NULL; -- 2.8.2