From: Max Reitz <mreitz@redhat.com>
To: qemu-block@nongnu.org
Cc: qemu-devel@nongnu.org, Max Reitz <mreitz@redhat.com>,
Kevin Wolf <kwolf@redhat.com>, Alberto Garcia <berto@igalia.com>
Subject: [Qemu-devel] [PATCH v4 5/9] block: Drop bdrv_new_root()
Date: Tue, 17 May 2016 16:41:30 +0200 [thread overview]
Message-ID: <1463496094-21608-6-git-send-email-mreitz@redhat.com> (raw)
In-Reply-To: <1463496094-21608-1-git-send-email-mreitz@redhat.com>
It is unused now, so we may just as well drop it.
Signed-off-by: Max Reitz <mreitz@redhat.com>
Reviewed-by: Alberto Garcia <berto@igalia.com>
Reviewed-by: Kevin Wolf <kwolf@redhat.com>
---
block.c | 5 -----
include/block/block.h | 1 -
2 files changed, 6 deletions(-)
diff --git a/block.c b/block.c
index b50b109..6e8ef5e 100644
--- a/block.c
+++ b/block.c
@@ -220,11 +220,6 @@ void bdrv_register(BlockDriver *bdrv)
QLIST_INSERT_HEAD(&bdrv_drivers, bdrv, list);
}
-BlockDriverState *bdrv_new_root(void)
-{
- return bdrv_new();
-}
-
BlockDriverState *bdrv_new(void)
{
BlockDriverState *bs;
diff --git a/include/block/block.h b/include/block/block.h
index a8c15e3..fe76fd3 100644
--- a/include/block/block.h
+++ b/include/block/block.h
@@ -198,7 +198,6 @@ BlockDriver *bdrv_find_format(const char *format_name);
int bdrv_create(BlockDriver *drv, const char* filename,
QemuOpts *opts, Error **errp);
int bdrv_create_file(const char *filename, QemuOpts *opts, Error **errp);
-BlockDriverState *bdrv_new_root(void);
BlockDriverState *bdrv_new(void);
void bdrv_append(BlockDriverState *bs_new, BlockDriverState *bs_top);
void bdrv_replace_in_backing_chain(BlockDriverState *old,
--
2.8.2
next prev parent reply other threads:[~2016-05-17 14:42 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-17 14:41 [Qemu-devel] [PATCH v4 0/9] blockdev: (Nearly) free clean-up work Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 1/9] block: Drop useless bdrv_new() call Max Reitz
2016-05-17 15:23 ` Eric Blake
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 2/9] block: Let bdrv_open_inherit() return the snapshot Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 3/9] tests: Drop BDS from test-throttle.c Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 4/9] block: Drop blk_new_with_bs() Max Reitz
2016-05-17 14:41 ` Max Reitz [this message]
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 6/9] block: Make bdrv_open() return a BDS Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 7/9] block: Assert !bs->refcnt in bdrv_close() Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 8/9] block: Drop bdrv_parent_cb_...() from bdrv_close() Max Reitz
2016-05-17 14:41 ` [Qemu-devel] [PATCH v4 9/9] block: Drop errp parameter from blk_new() Max Reitz
2016-05-23 11:09 ` [Qemu-devel] [PATCH v4 0/9] blockdev: (Nearly) free clean-up work Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463496094-21608-6-git-send-email-mreitz@redhat.com \
--to=mreitz@redhat.com \
--cc=berto@igalia.com \
--cc=kwolf@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).