From: Paolo Bonzini <pbonzini@redhat.com>
To: qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 46/52] arm: move arm_log_exception into .c file
Date: Thu, 19 May 2016 13:18:40 +0200 [thread overview]
Message-ID: <1463656726-35952-47-git-send-email-pbonzini@redhat.com> (raw)
In-Reply-To: <1463656726-35952-1-git-send-email-pbonzini@redhat.com>
Avoid need for qemu/log.h inclusion, and make the function static too.
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
---
target-arm/helper.c | 15 +++++++++++++++
target-arm/internals.h | 15 ---------------
2 files changed, 15 insertions(+), 15 deletions(-)
diff --git a/target-arm/helper.c b/target-arm/helper.c
index a2ab701..d721c0c 100644
--- a/target-arm/helper.c
+++ b/target-arm/helper.c
@@ -5819,6 +5819,21 @@ static void do_v7m_exception_exit(CPUARMState *env)
pointer. */
}
+static void arm_log_exception(int idx)
+{
+ if (qemu_loglevel_mask(CPU_LOG_INT)) {
+ const char *exc = NULL;
+
+ if (idx >= 0 && idx < ARRAY_SIZE(excnames)) {
+ exc = excnames[idx];
+ }
+ if (!exc) {
+ exc = "unknown";
+ }
+ qemu_log_mask(CPU_LOG_INT, "Taking exception %d [%s]\n", idx, exc);
+ }
+}
+
void arm_v7m_cpu_do_interrupt(CPUState *cs)
{
ARMCPU *cpu = ARM_CPU(cs);
diff --git a/target-arm/internals.h b/target-arm/internals.h
index 54a0fb1..a125873 100644
--- a/target-arm/internals.h
+++ b/target-arm/internals.h
@@ -72,21 +72,6 @@ static const char * const excnames[] = {
[EXCP_SEMIHOST] = "Semihosting call",
};
-static inline void arm_log_exception(int idx)
-{
- if (qemu_loglevel_mask(CPU_LOG_INT)) {
- const char *exc = NULL;
-
- if (idx >= 0 && idx < ARRAY_SIZE(excnames)) {
- exc = excnames[idx];
- }
- if (!exc) {
- exc = "unknown";
- }
- qemu_log_mask(CPU_LOG_INT, "Taking exception %d [%s]\n", idx, exc);
- }
-}
-
/* Scale factor for generic timers, ie number of ns per tick.
* This gives a 62.5MHz timer.
*/
--
1.8.3.1
next prev parent reply other threads:[~2016-05-19 11:19 UTC|newest]
Thread overview: 55+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-19 11:17 [Qemu-devel] [PULL 00/52] NEED_CPU_H cleanups Paolo Bonzini
2016-05-19 11:17 ` [Qemu-devel] [PULL 01/52] scripts: add script to build QEMU and analyze inclusions Paolo Bonzini
2016-05-19 11:17 ` [Qemu-devel] [PULL 02/52] s390x: move .needed functions for subsections to machine.c Paolo Bonzini
2016-05-19 11:17 ` [Qemu-devel] [PULL 03/52] include: move CPU-related definitions out of qemu-common.h Paolo Bonzini
2016-05-19 11:17 ` [Qemu-devel] [PULL 04/52] log: do not use CONFIG_USER_ONLY Paolo Bonzini
2016-05-19 11:17 ` [Qemu-devel] [PULL 05/52] cpu: make cpu-qom.h only include-able from cpu.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 06/52] target-alpha: make cpu-qom.h not target specific Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 07/52] target-arm: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 08/52] target-cris: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 09/52] target-i386: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 10/52] target-lm32: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 11/52] target-m68k: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 12/52] target-microblaze: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 13/52] target-mips: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 14/52] target-ppc: do not use target_ulong in cpu-qom.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 15/52] target-ppc: do not make PowerPCCPUClass depend on target-specific symbols Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 16/52] target-ppc: make cpu-qom.h not target specific Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 17/52] target-s390x: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 18/52] target-sh4: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 19/52] target-sparc: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 20/52] target-tricore: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 21/52] target-unicore32: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 22/52] target-xtensa: " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 23/52] arm: include cpu-qom.h in files that require ARMCPU Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 24/52] m68k: include cpu-qom.h in files that require M68KCPU Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 25/52] sh4: include cpu-qom.h in files that require SuperHCPU Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 26/52] alpha: include cpu-qom.h in files that require AlphaCPU Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 27/52] mips: use MIPSCPU instead of CPUMIPSState Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 28/52] ppc: use PowerPCCPU instead of CPUPPCState Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 29/52] arm: remove useless cpu.h inclusion Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 30/52] explicitly include qom/cpu.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 31/52] explicitly include hw/qdev-core.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 32/52] explicitly include linux/kvm.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 33/52] apic: move target-dependent definitions to cpu.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 34/52] include: poison symbols in osdep.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 35/52] hw: do not use VMSTATE_*TL Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 36/52] hw: move CPU state serialization to migration/cpu.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 37/52] hw: cannot include hw/hw.h from user emulation Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 38/52] cpu: move endian-dependent load/store functions to cpu-all.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 39/52] qemu-common: stop including qemu/bswap.h from qemu-common.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 40/52] qemu-common: stop including qemu/host-utils.h " Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 41/52] gdbstub: remove unnecessary includes from gdbstub-xml.c Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 42/52] dma: do not depend on kvm_enabled() Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 43/52] s390x: reorganize CSS bits between cpu.h and other headers Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 44/52] acpi: do not use TARGET_PAGE_SIZE Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 45/52] qemu-common: push cpu.h inclusion out of qemu-common.h Paolo Bonzini
2016-05-19 11:18 ` Paolo Bonzini [this message]
2016-05-19 11:18 ` [Qemu-devel] [PULL 47/52] mips: move CP0 functions out of cpu.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 48/52] hw: explicitly include qemu/log.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 49/52] exec: extract exec/tb-context.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 50/52] cpu: move exec-all.h inclusion out of cpu.h Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 51/52] hw: remove pio_addr_t Paolo Bonzini
2016-05-19 11:18 ` [Qemu-devel] [PULL 52/52] hw: clean up hw/hw.h includes Paolo Bonzini
2016-05-19 11:59 ` [Qemu-devel] [PULL 00/52] NEED_CPU_H cleanups Peter Maydell
2016-05-19 12:08 ` Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463656726-35952-47-git-send-email-pbonzini@redhat.com \
--to=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).