qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Bandan Das <bsd@redhat.com>
To: qemu-devel@nongnu.org
Cc: pbonzini@redhat.com, aik@ozlabs.ru
Subject: [Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function
Date: Thu, 19 May 2016 18:15:16 -0400	[thread overview]
Message-ID: <1463696116-31631-5-git-send-email-bsd@redhat.com> (raw)
In-Reply-To: <1463696116-31631-1-git-send-email-bsd@redhat.com>

Now that the common functions are in place, we can call it
instead of duplicating code.

Signed-off-by: Bandan Das <bsd@redhat.com>
---
 cpus.c | 16 +---------------
 1 file changed, 1 insertion(+), 15 deletions(-)

diff --git a/cpus.c b/cpus.c
index eb34b4f..ead4e3f 100644
--- a/cpus.c
+++ b/cpus.c
@@ -1693,21 +1693,7 @@ exit:
 
 void qmp_inject_nmi(Error **errp)
 {
-#if defined(TARGET_I386)
-    CPUState *cs;
-
-    CPU_FOREACH(cs) {
-        X86CPU *cpu = X86_CPU(cs);
-
-        if (!cpu->apic_state) {
-            cpu_interrupt(cs, CPU_INTERRUPT_NMI);
-        } else {
-            apic_deliver_nmi(cpu->apic_state);
-        }
-    }
-#else
-    nmi_monitor_handle(monitor_get_cpu_index(), errp);
-#endif
+    inject_nmi(errp);
 }
 
 void dump_drift_info(FILE *f, fprintf_function cpu_fprintf)
-- 
2.5.5

  parent reply	other threads:[~2016-05-19 22:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-19 22:15 [Qemu-devel] [PATCH 0/4] Minor nmi cleanups Bandan Das
2016-05-19 22:15 ` [Qemu-devel] [PATCH 1/4] target-i386: add a generic x86 nmi handler Bandan Das
2016-05-19 22:15 ` [Qemu-devel] [PATCH 2/4] nmi: remove x86 specific nmi handling Bandan Das
2016-05-19 22:15 ` [Qemu-devel] [PATCH 3/4] nmi: add errp function parameter to inject_nmi() Bandan Das
2016-05-19 22:15 ` Bandan Das [this message]
2016-05-20  7:50   ` [Qemu-devel] [PATCH 4/4] cpus: call the core nmi injection function Paolo Bonzini
2016-05-20 16:29     ` Bandan Das
2016-05-20  7:50   ` Paolo Bonzini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463696116-31631-5-git-send-email-bsd@redhat.com \
    --to=bsd@redhat.com \
    --cc=aik@ozlabs.ru \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).