From: Gerd Hoffmann <kraxel@redhat.com>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-devel@nongnu.org, "Marc-André Lureau" <marcandre.lureau@redhat.com>
Subject: Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl
Date: Fri, 20 May 2016 07:53:26 +0200 [thread overview]
Message-ID: <1463723606.3526.7.camel@redhat.com> (raw)
In-Reply-To: <543c98f507a30a92c42f1d240b47ad90f0efdad3.1463588606.git.crobinso@redhat.com>
On Mi, 2016-05-18 at 12:40 -0400, Cole Robinson wrote:
> Give users a hint if their config is wrong.
>
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> If virgl support is built into qemu, virgl=on is the default, so this
> could be noisy in cases where people don't even care about virgl. So
> I won't object if this is dropped.
Yes, it's enabled by default, so users have to flip one switch only
(-spice gl=on) to enable 3d, not two. So warning here is a bad thing
IMO.
We could turn the virgl switch into tristate (OnOffAuto), have it
default to Auto, then fail (not warn) in case it is set to On without 3d
support being available.
I'll go cherry-pick #1+#2.
cheers,
Gerd
next prev parent reply other threads:[~2016-05-20 5:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-18 16:40 [Qemu-devel] [PATCH 0/3] ui: improve feedback if gl setup fails Cole Robinson
2016-05-18 16:40 ` [Qemu-devel] [PATCH 1/3] ui: egl: Replace fprintf with error_report Cole Robinson
2016-05-18 16:50 ` Eric Blake
2016-05-19 15:19 ` Marc-André Lureau
2016-05-18 16:40 ` [Qemu-devel] [PATCH 2/3] ui: spice: Exit if gl=on EGL init fails Cole Robinson
2016-05-19 15:19 ` Marc-André Lureau
2016-05-18 16:40 ` [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will disable virgl Cole Robinson
2016-05-19 15:19 ` Marc-André Lureau
2016-05-20 5:53 ` Gerd Hoffmann [this message]
2016-05-20 14:49 ` Cole Robinson
2016-05-23 7:34 ` Gerd Hoffmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463723606.3526.7.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=crobinso@redhat.com \
--cc=marcandre.lureau@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).