From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52554)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b3dNP-0000Om-GX
	for qemu-devel@nongnu.org; Fri, 20 May 2016 01:53:36 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b3dNJ-0001aY-In
	for qemu-devel@nongnu.org; Fri, 20 May 2016 01:53:34 -0400
Received: from mx1.redhat.com ([209.132.183.28]:34953)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b3dNJ-0001aT-CR
	for qemu-devel@nongnu.org; Fri, 20 May 2016 01:53:29 -0400
Received: from int-mx09.intmail.prod.int.phx2.redhat.com
	(int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22])
	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
	(No client certificate requested)
	by mx1.redhat.com (Postfix) with ESMTPS id A29A949469
	for <qemu-devel@nongnu.org>; Fri, 20 May 2016 05:53:28 +0000 (UTC)
Message-ID: <1463723606.3526.7.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Fri, 20 May 2016 07:53:26 +0200
In-Reply-To: <543c98f507a30a92c42f1d240b47ad90f0efdad3.1463588606.git.crobinso@redhat.com>
References: <cover.1463588606.git.crobinso@redhat.com>
	<543c98f507a30a92c42f1d240b47ad90f0efdad3.1463588606.git.crobinso@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH 3/3] virtio-gpu: Warn if UI config will
 disable virgl
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Cole Robinson <crobinso@redhat.com>
Cc: qemu-devel@nongnu.org, =?ISO-8859-1?Q?Marc-Andr=E9?= Lureau <marcandre.lureau@redhat.com>

On Mi, 2016-05-18 at 12:40 -0400, Cole Robinson wrote:
> Give users a hint if their config is wrong.
>=20
> Signed-off-by: Cole Robinson <crobinso@redhat.com>
> ---
> If virgl support is built into qemu, virgl=3Don is the default, so this
> could be noisy in cases where people don't even care about virgl. So
> I won't object if this is dropped.

Yes, it's enabled by default, so users have to flip one switch only
(-spice gl=3Don) to enable 3d, not two.  So warning here is a bad thing
IMO.

We could turn the virgl switch into tristate (OnOffAuto), have it
default to Auto, then fail (not warn) in case it is set to On without 3d
support being available.

I'll go cherry-pick #1+#2.

cheers,
  Gerd