[Qemu-devel] [PATCH] scripts/kvm/kvm_stat: define exit_reasons field in ArchPPC

[Qemu-devel] [PATCH] scripts/kvm/kvm_stat: define exit_reasons field in ArchPPC

[Laurent Vivier]

Otherwise kvm_stat fails with the following error:

    AttributeError: 'ArchPPC' object has no attribute 'exit_reasons'

This has been introduced by:

    068294a scripts/kvm/kvm_stat: Group arch specific data

Set exit_reasons to 'None' (as it is done for ArchS390) for ArchPPC.

Test this with "kvm_stat -d" as tracepoints provider (-t) is
also broken on PPC (looks like a kernel bug).

Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 scripts/kvm/kvm_stat | 1 +
 1 file changed, 1 insertion(+)

diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
index 769d884..78ffe83 100755
--- a/scripts/kvm/kvm_stat
+++ b/scripts/kvm/kvm_stat
@@ -261,6 +261,7 @@ class ArchPPC(Arch):
         # numbers depend on the wordsize.
         char_ptr_size = ctypes.sizeof(ctypes.c_char_p)
         self.ioctl_numbers['SET_FILTER'] = 0x80002406 | char_ptr_size << 16
+        self.exit_reasons = None
 
 class ArchA64(Arch):
     def __init__(self):
-- 
2.5.5

Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: define exit_reasons field in ArchPPC

[Laurent Vivier]

On 20/05/2016 09:07, Laurent Vivier wrote:
> Otherwise kvm_stat fails with the following error:
> 
>     AttributeError: 'ArchPPC' object has no attribute 'exit_reasons'
> 
> This has been introduced by:
> 
>     068294a scripts/kvm/kvm_stat: Group arch specific data
> 
> Set exit_reasons to 'None' (as it is done for ArchS390) for ArchPPC.
> 
> Test this with "kvm_stat -d" as tracepoints provider (-t) is
> also broken on PPC (looks like a kernel bug).

For this part, I've found the ioctl number used to reset the event queue
is not the good one on PPC (thanks to systemtap), I'm going to send
another patch to fix that too.

Laurent
> 
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
>  scripts/kvm/kvm_stat | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 769d884..78ffe83 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -261,6 +261,7 @@ class ArchPPC(Arch):
>          # numbers depend on the wordsize.
>          char_ptr_size = ctypes.sizeof(ctypes.c_char_p)
>          self.ioctl_numbers['SET_FILTER'] = 0x80002406 | char_ptr_size << 16
> +        self.exit_reasons = None
>  
>  class ArchA64(Arch):
>      def __init__(self):
>