qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Xiao Guangrong <guangrong.xiao@linux.intel.com>
To: pbonzini@redhat.com, imammedo@redhat.com
Cc: gleb@kernel.org, mtosatti@redhat.com, stefanha@redhat.com,
	mst@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	dan.j.williams@intel.com, kvm@vger.kernel.org,
	qemu-devel@nongnu.org,
	Xiao Guangrong <guangrong.xiao@linux.intel.com>
Subject: [Qemu-devel] [PATCH v2 01/15] pc-dimm: get memory region from ->get_memory_region()
Date: Fri, 20 May 2016 16:19:58 +0800	[thread overview]
Message-ID: <1463732412-99212-2-git-send-email-guangrong.xiao@linux.intel.com> (raw)
In-Reply-To: <1463732412-99212-1-git-send-email-guangrong.xiao@linux.intel.com>

Curretly, the memory region of backed memory is all directly
mapped to guest's address space, however, it will be not true
for nvdimm device if we introduce nvdimm label which only can
be indirectly accessed by ACPI DSM method

Also it improves the comments a bit to reflect this fact

Signed-off-by: Xiao Guangrong <guangrong.xiao@linux.intel.com>
---
 hw/mem/pc-dimm.c         | 3 ++-
 include/hw/mem/pc-dimm.h | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c
index 9e7de56..70b9451 100644
--- a/hw/mem/pc-dimm.c
+++ b/hw/mem/pc-dimm.c
@@ -354,8 +354,9 @@ static void pc_dimm_get_size(Object *obj, Visitor *v, const char *name,
     int64_t value;
     MemoryRegion *mr;
     PCDIMMDevice *dimm = PC_DIMM(obj);
+    PCDIMMDeviceClass *ddc = PC_DIMM_GET_CLASS(obj);
 
-    mr = host_memory_backend_get_memory(dimm->hostmem, errp);
+    mr = ddc->get_memory_region(dimm);
     value = memory_region_size(mr);
 
     visit_type_int(v, name, &value, errp);
diff --git a/include/hw/mem/pc-dimm.h b/include/hw/mem/pc-dimm.h
index 218dfb0..827f1bc 100644
--- a/include/hw/mem/pc-dimm.h
+++ b/include/hw/mem/pc-dimm.h
@@ -60,7 +60,8 @@ typedef struct PCDIMMDevice {
 
 /**
  * PCDIMMDeviceClass:
- * @get_memory_region: returns #MemoryRegion associated with @dimm
+ * @get_memory_region: returns #MemoryRegion associated with @dimm which
+ * is directly mapped into the physical address space of guest
  */
 typedef struct PCDIMMDeviceClass {
     /* private */
-- 
1.8.3.1

  reply	other threads:[~2016-05-20  8:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-20  8:19 [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support Xiao Guangrong
2016-05-20  8:19 ` Xiao Guangrong [this message]
2016-05-30 18:36   ` [Qemu-devel] [PATCH v2 01/15] pc-dimm: get memory region from ->get_memory_region() Stefan Hajnoczi
2016-05-20  8:19 ` [Qemu-devel] [PATCH v2 02/15] pc-dimm: introduce realize callback Xiao Guangrong
2016-05-30 18:37   ` Stefan Hajnoczi
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 03/15] pc-dimm: keep the state of the whole backend memory Xiao Guangrong
2016-05-30 18:42   ` Stefan Hajnoczi
2016-05-31  2:04     ` Xiao Guangrong
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 04/15] nvdimm: support nvdimm label Xiao Guangrong
2016-05-30 18:46   ` Stefan Hajnoczi
2016-06-28  7:48   ` Paolo Bonzini
2016-06-28  9:04     ` Stefan Hajnoczi
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 05/15] acpi: add aml_object_type Xiao Guangrong
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 06/15] acpi: add aml_call5 Xiao Guangrong
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 07/15] nvdimm acpi: set HDLE properly Xiao Guangrong
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 08/15] nvdimm acpi: save arg3 of _DSM method Xiao Guangrong
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 09/15] nvdimm acpi: check UUID Xiao Guangrong
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 10/15] nvdimm acpi: abstract the operations for root & nvdimm devices Xiao Guangrong
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 11/15] nvdimm acpi: check revision Xiao Guangrong
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 12/15] nvdimm acpi: support Get Namespace Label Size function Xiao Guangrong
2016-05-30 18:49   ` Stefan Hajnoczi
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 13/15] nvdimm acpi: support Get Namespace Label Data function Xiao Guangrong
2016-05-30 18:51   ` Stefan Hajnoczi
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 14/15] nvdimm acpi: support Set " Xiao Guangrong
2016-05-30 18:51   ` Stefan Hajnoczi
2016-05-20  8:20 ` [Qemu-devel] [PATCH v2 15/15] docs: add NVDIMM ACPI documentation Xiao Guangrong
2016-05-30 18:52 ` [Qemu-devel] [PATCH v2 00/15] PATCH 00/15] NVDIMM: introduce nvdimm label support Stefan Hajnoczi
2016-05-31  2:09   ` Xiao Guangrong

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1463732412-99212-2-git-send-email-guangrong.xiao@linux.intel.com \
    --to=guangrong.xiao@linux.intel.com \
    --cc=dan.j.williams@intel.com \
    --cc=ehabkost@redhat.com \
    --cc=gleb@kernel.org \
    --cc=imammedo@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=mst@redhat.com \
    --cc=mtosatti@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rth@twiddle.net \
    --cc=stefanha@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).