* [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: fix tracepoint provider
@ 2016-05-20 8:42 Laurent Vivier
2016-05-23 13:51 ` Paolo Bonzini
0 siblings, 1 reply; 3+ messages in thread
From: Laurent Vivier @ 2016-05-20 8:42 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-ppc, Janosch Frank, Paolo Bonzini, Laurent Vivier
tracepoint provider on ppc is broken since:
fc116ef kvm_stat: Add RESET support for perf event ioctl
because the value used with ioctl() to reset the event queue is
not valid on ppc.
This patch defines the good value for ppc.
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
scripts/kvm/kvm_stat | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
index 78ffe83..c547c9b 100755
--- a/scripts/kvm/kvm_stat
+++ b/scripts/kvm/kvm_stat
@@ -256,6 +256,7 @@ class ArchPPC(Arch):
self.ioctl_numbers = IOCTL_NUMBERS
self.ioctl_numbers['ENABLE'] = 0x20002400
self.ioctl_numbers['DISABLE'] = 0x20002401
+ self.ioctl_numbers['RESET'] = 0x20002403
# PPC comes in 32 and 64 bit and some generated ioctl
# numbers depend on the wordsize.
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: fix tracepoint provider
2016-05-20 8:42 [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: fix tracepoint provider Laurent Vivier
@ 2016-05-23 13:51 ` Paolo Bonzini
2016-05-23 13:56 ` Laurent Vivier
0 siblings, 1 reply; 3+ messages in thread
From: Paolo Bonzini @ 2016-05-23 13:51 UTC (permalink / raw)
To: Laurent Vivier, qemu-devel; +Cc: Janosch Frank, qemu-ppc
On 20/05/2016 10:42, Laurent Vivier wrote:
> tracepoint provider on ppc is broken since:
>
> fc116ef kvm_stat: Add RESET support for perf event ioctl
>
> because the value used with ioctl() to reset the event queue is
> not valid on ppc.
>
> This patch defines the good value for ppc.
>
> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
> ---
> scripts/kvm/kvm_stat | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
> index 78ffe83..c547c9b 100755
> --- a/scripts/kvm/kvm_stat
> +++ b/scripts/kvm/kvm_stat
> @@ -256,6 +256,7 @@ class ArchPPC(Arch):
> self.ioctl_numbers = IOCTL_NUMBERS
> self.ioctl_numbers['ENABLE'] = 0x20002400
> self.ioctl_numbers['DISABLE'] = 0x20002401
> + self.ioctl_numbers['RESET'] = 0x20002403
>
> # PPC comes in 32 and 64 bit and some generated ioctl
> # numbers depend on the wordsize.
>
I've queued http://permalink.gmane.org/gmane.comp.emulators.qemu/407322
- however, note that kvm_stat is moving to the kernel tree.
Thanks,
Paolo
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: fix tracepoint provider
2016-05-23 13:51 ` Paolo Bonzini
@ 2016-05-23 13:56 ` Laurent Vivier
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Vivier @ 2016-05-23 13:56 UTC (permalink / raw)
To: Paolo Bonzini, qemu-devel; +Cc: Janosch Frank, qemu-ppc
On 23/05/2016 15:51, Paolo Bonzini wrote:
>
>
> On 20/05/2016 10:42, Laurent Vivier wrote:
>> tracepoint provider on ppc is broken since:
>>
>> fc116ef kvm_stat: Add RESET support for perf event ioctl
>>
>> because the value used with ioctl() to reset the event queue is
>> not valid on ppc.
>>
>> This patch defines the good value for ppc.
>>
>> Signed-off-by: Laurent Vivier <lvivier@redhat.com>
>> ---
>> scripts/kvm/kvm_stat | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/scripts/kvm/kvm_stat b/scripts/kvm/kvm_stat
>> index 78ffe83..c547c9b 100755
>> --- a/scripts/kvm/kvm_stat
>> +++ b/scripts/kvm/kvm_stat
>> @@ -256,6 +256,7 @@ class ArchPPC(Arch):
>> self.ioctl_numbers = IOCTL_NUMBERS
>> self.ioctl_numbers['ENABLE'] = 0x20002400
>> self.ioctl_numbers['DISABLE'] = 0x20002401
>> + self.ioctl_numbers['RESET'] = 0x20002403
>>
>> # PPC comes in 32 and 64 bit and some generated ioctl
>> # numbers depend on the wordsize.
>>
>
> I've queued http://permalink.gmane.org/gmane.comp.emulators.qemu/407322
> - however, note that kvm_stat is moving to the kernel tree.
Thanks, that's fine.
Laurent
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-05-23 13:56 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-20 8:42 [Qemu-devel] [PATCH] scripts/kvm/kvm_stat: fix tracepoint provider Laurent Vivier
2016-05-23 13:51 ` Paolo Bonzini
2016-05-23 13:56 ` Laurent Vivier
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).