From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:44199) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3t8U-0001GG-MV for qemu-devel@nongnu.org; Fri, 20 May 2016 18:43:18 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b3r2Y-000168-Di for qemu-devel@nongnu.org; Fri, 20 May 2016 16:29:04 -0400 Received: from mx1.redhat.com ([209.132.183.28]:36018) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b3r2Y-000164-8W for qemu-devel@nongnu.org; Fri, 20 May 2016 16:28:58 -0400 From: Eduardo Habkost Date: Fri, 20 May 2016 17:28:22 -0300 Message-Id: <1463776121-13529-3-git-send-email-ehabkost@redhat.com> In-Reply-To: <1463776121-13529-1-git-send-email-ehabkost@redhat.com> References: <1463776121-13529-1-git-send-email-ehabkost@redhat.com> Subject: [Qemu-devel] [PULL 02/21] vl: Use exit(1) when requested VGA interface is unavailable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Peter Maydell Cc: Paolo Bonzini , "Michael S. Tsirkin" , Marcel Apfelbaum , qemu-devel@nongnu.org Instead of using exit(0), use exit(1) when an unavailable VGA interface is used in the command-line to indicate it's an error. Reviewed-by: Eric Blake Reviewed-by: Marcel Apfelbaum Signed-off-by: Eduardo Habkost --- vl.c | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/vl.c b/vl.c index a43a3ba..edfb5b9 100644 --- a/vl.c +++ b/vl.c @@ -2027,28 +2027,28 @@ static void select_vgahw (const char *p) vga_interface_type = VGA_STD; } else { error_report("standard VGA not available"); - exit(0); + exit(1); } } else if (strstart(p, "cirrus", &opts)) { if (cirrus_vga_available()) { vga_interface_type = VGA_CIRRUS; } else { error_report("Cirrus VGA not available"); - exit(0); + exit(1); } } else if (strstart(p, "vmware", &opts)) { if (vmware_vga_available()) { vga_interface_type = VGA_VMWARE; } else { error_report("VMWare SVGA not available"); - exit(0); + exit(1); } } else if (strstart(p, "virtio", &opts)) { if (virtio_vga_available()) { vga_interface_type = VGA_VIRTIO; } else { error_report("Virtio VGA not available"); - exit(0); + exit(1); } } else if (strstart(p, "xenfb", &opts)) { vga_interface_type = VGA_XENFB; @@ -2057,21 +2057,21 @@ static void select_vgahw (const char *p) vga_interface_type = VGA_QXL; } else { error_report("QXL VGA not available"); - exit(0); + exit(1); } } else if (strstart(p, "tcx", &opts)) { if (tcx_vga_available()) { vga_interface_type = VGA_TCX; } else { error_report("TCX framebuffer not available"); - exit(0); + exit(1); } } else if (strstart(p, "cg3", &opts)) { if (cg3_vga_available()) { vga_interface_type = VGA_CG3; } else { error_report("CG3 framebuffer not available"); - exit(0); + exit(1); } } else if (!strstart(p, "none", &opts)) { invalid_vga: -- 2.5.5