From: Eduardo Habkost <ehabkost@redhat.com>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Paolo Bonzini <pbonzini@redhat.com>,
"Michael S. Tsirkin" <mst@redhat.com>,
Marcel Apfelbaum <marcel@redhat.com>,
qemu-devel@nongnu.org
Subject: [Qemu-devel] [PULL 08/21] sdl: Initialization stubs
Date: Fri, 20 May 2016 17:28:28 -0300 [thread overview]
Message-ID: <1463776121-13529-9-git-send-email-ehabkost@redhat.com> (raw)
In-Reply-To: <1463776121-13529-1-git-send-email-ehabkost@redhat.com>
This reduces the number of CONFIG_SDL #ifdefs in vl.c.
Signed-off-by: Eduardo Habkost <ehabkost@redhat.com>
---
include/ui/console.h | 16 ++++++++++++++++
vl.c | 6 ++----
2 files changed, 18 insertions(+), 4 deletions(-)
diff --git a/include/ui/console.h b/include/ui/console.h
index f5fa9cb..f3e749d 100644
--- a/include/ui/console.h
+++ b/include/ui/console.h
@@ -422,8 +422,24 @@ void surface_gl_setup_viewport(ConsoleGLState *gls,
#endif
/* sdl.c */
+#ifdef CONFIG_SDL
void sdl_display_early_init(int opengl);
void sdl_display_init(DisplayState *ds, int full_screen, int no_frame);
+#else
+static inline void sdl_display_early_init(int opengl)
+{
+ /* This must never be called if CONFIG_SDL is disabled */
+ error_report("SDL support is disabled");
+ abort();
+}
+static inline void sdl_display_init(DisplayState *ds, int full_screen,
+ int no_frame)
+{
+ /* This must never be called if CONFIG_SDL is disabled */
+ error_report("SDL support is disabled");
+ abort();
+}
+#endif
/* cocoa.m */
void cocoa_display_init(DisplayState *ds, int full_screen);
diff --git a/vl.c b/vl.c
index c852d10..d5df442 100644
--- a/vl.c
+++ b/vl.c
@@ -4251,11 +4251,10 @@ int main(int argc, char **argv, char **envp)
early_gtk_display_init(request_opengl);
}
#endif
-#if defined(CONFIG_SDL)
if (display_type == DT_SDL) {
sdl_display_early_init(request_opengl);
}
-#endif
+
if (request_opengl == 1 && display_opengl == 0) {
#if defined(CONFIG_OPENGL)
error_report("OpenGL is not supported by the display");
@@ -4543,11 +4542,10 @@ int main(int argc, char **argv, char **envp)
case DT_CURSES:
curses_display_init(ds, full_screen);
break;
-#if defined(CONFIG_SDL)
case DT_SDL:
sdl_display_init(ds, full_screen, no_frame);
break;
-#elif defined(CONFIG_COCOA)
+#if defined(CONFIG_COCOA)
case DT_COCOA:
cocoa_display_init(ds, full_screen);
break;
--
2.5.5
next prev parent reply other threads:[~2016-05-20 22:43 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-20 20:28 [Qemu-devel] [PULL 00/21] Machine Core queue, 2016-05-20 Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 01/21] pc-dimm: correct comment of MemoryHotplugState Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 02/21] vl: Use exit(1) when requested VGA interface is unavailable Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 03/21] vl: Table-based select_vgahw() Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 04/21] vl: Replace *_vga_available() functions with class_names field Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 05/21] vl: Add DT_COCOA DisplayType value Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 06/21] vnc: Initialization stubs Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 07/21] curses: curses_display_init() stub Eduardo Habkost
2016-05-20 20:28 ` Eduardo Habkost [this message]
2016-05-20 20:28 ` [Qemu-devel] [PULL 09/21] cocoa: cocoa_display_init() stub Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 10/21] gtk: Initialization stubs Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 11/21] spice: Initialization stubs on qemu-spice.h Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 12/21] milkymist: Move DT_NOGRAPHIC check outside milkymist_tmu2_create() Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 13/21] vl: Replace DT_NOGRAPHIC with machine option Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 14/21] vl: Make display_type a local variable Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 15/21] vl: Move DisplayType typedef to vl.c Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 16/21] vl: Make display_remote a local variable Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 17/21] vl: Simplify global property registration Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 18/21] machine: add properties to compat_props incrementaly Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 19/21] vl: Use &error_fatal when parsing VNC options Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 20/21] vl: Use &error_fatal when parsing monitor options Eduardo Habkost
2016-05-20 20:28 ` [Qemu-devel] [PULL 21/21] Use &error_fatal when initializing crypto on qemu-{img, io, nbd} Eduardo Habkost
2016-05-23 10:27 ` [Qemu-devel] [PULL 00/21] Machine Core queue, 2016-05-20 Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1463776121-13529-9-git-send-email-ehabkost@redhat.com \
--to=ehabkost@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).