From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:49516) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4fNm-0007rL-Gb for qemu-devel@nongnu.org; Sun, 22 May 2016 22:14:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4fNl-0002d5-9r for qemu-devel@nongnu.org; Sun, 22 May 2016 22:14:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:44195) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4fNl-0002ct-3h for qemu-devel@nongnu.org; Sun, 22 May 2016 22:14:13 -0400 From: Jason Wang Date: Mon, 23 May 2016 10:13:44 +0800 Message-Id: <1463969642-5908-3-git-send-email-jasowang@redhat.com> In-Reply-To: <1463969642-5908-1-git-send-email-jasowang@redhat.com> References: <1463969642-5908-1-git-send-email-jasowang@redhat.com> Subject: [Qemu-devel] [PULL 02/20] net: mipsnet: check packet length against buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: peter.maydell@linaro.org, qemu-devel@nongnu.org Cc: Prasad J Pandit , Jason Wang From: Prasad J Pandit When receiving packets over MIPSnet network device, it uses receive buffer of size 1514 bytes. In case the controller accepts large(MTU) packets, it could lead to memory corruption. Add check to avoid it. Reported by: Oleksandr Bazhaniuk Signed-off-by: Prasad J Pandit Signed-off-by: Jason Wang --- hw/net/mipsnet.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/net/mipsnet.c b/hw/net/mipsnet.c index 740cd98..cf8b823 100644 --- a/hw/net/mipsnet.c +++ b/hw/net/mipsnet.c @@ -83,6 +83,9 @@ static ssize_t mipsnet_receive(NetClientState *nc, const uint8_t *buf, size_t si if (!mipsnet_can_receive(nc)) return 0; + if (size >= sizeof(s->rx_buffer)) { + return 0; + } s->busy = 1; /* Just accept everything. */ -- 2.7.4