From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37616) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4rUs-0002Fj-Pd for qemu-devel@nongnu.org; Mon, 23 May 2016 11:10:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b4rUq-00047t-SQ for qemu-devel@nongnu.org; Mon, 23 May 2016 11:10:21 -0400 Received: from mail-wm0-x243.google.com ([2a00:1450:400c:c09::243]:33980) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b4rUp-00047W-UJ for qemu-devel@nongnu.org; Mon, 23 May 2016 11:10:20 -0400 Received: by mail-wm0-x243.google.com with SMTP id n129so16052832wmn.1 for ; Mon, 23 May 2016 08:10:19 -0700 (PDT) Sender: Paolo Bonzini From: Paolo Bonzini Date: Mon, 23 May 2016 17:09:52 +0200 Message-Id: <1464016199-43768-18-git-send-email-pbonzini@redhat.com> In-Reply-To: <1464016199-43768-1-git-send-email-pbonzini@redhat.com> References: <1464016199-43768-1-git-send-email-pbonzini@redhat.com> Subject: [Qemu-devel] [PULL 17/24] scripts/signrom.py: Check for magic in option ROMs. List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: "Richard W.M. Jones" From: "Richard W.M. Jones" Because of the risk that compilers might not emit the asm() block at the beginning of the option ROM, check that the ROM contains the required magic signature. Signed-off-by: Richard W.M. Jones Message-Id: <1463000807-18015-3-git-send-email-rjones@redhat.com> Signed-off-by: Paolo Bonzini --- scripts/signrom.py | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/scripts/signrom.py b/scripts/signrom.py index 6c8b9bf..5629bca 100644 --- a/scripts/signrom.py +++ b/scripts/signrom.py @@ -17,7 +17,10 @@ if len(sys.argv) < 3: fin = open(sys.argv[1], 'rb') fout = open(sys.argv[2], 'wb') -fin.seek(2) +magic = fin.read(2) +if magic != '\x55\xaa': + sys.exit("%s: option ROM does not begin with magic 55 aa" % sys.argv[1]) + size_byte = ord(fin.read(1)) fin.seek(0) -- 1.8.3.1