From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:48608)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1b5GGu-0003k1-Fn
	for qemu-devel@nongnu.org; Tue, 24 May 2016 13:37:37 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1b5GGr-0004ae-3c
	for qemu-devel@nongnu.org; Tue, 24 May 2016 13:37:36 -0400
Received: from mail-oi0-x22d.google.com ([2607:f8b0:4003:c06::22d]:33850)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <tcminyard@gmail.com>) id 1b5GGq-0004a6-Tf
	for qemu-devel@nongnu.org; Tue, 24 May 2016 13:37:33 -0400
Received: by mail-oi0-x22d.google.com with SMTP id b65so38415529oia.1
	for <qemu-devel@nongnu.org>; Tue, 24 May 2016 10:37:32 -0700 (PDT)
Sender: Corey Minyard <tcminyard@gmail.com>
From: minyard@acm.org
Date: Tue, 24 May 2016 12:37:16 -0500
Message-Id: <1464111442-10387-1-git-send-email-minyard@acm.org>
Subject: [Qemu-devel] [PATCH v7 1/6] Add IPMI to firmware tables
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Igor Mammedov <imammedo@redhat.com>, "Michael S . Tsirkin" <mst@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>, qemu-devel@nongnu.org, minyard@acm.org, cminyard@mvista.com

One more time, with (hopefully) all necessary comments addressed:

Removed the stub code and went back to the makefile conditionals
for handling the no IPMI case.

Added asserts for catching spec version overflow.

Clean up the definitions in build_acpi_ipmi_devices().

Folded build_isa_ipmi_aml. into build_isa_devices_aml().

Removed the now unnecessary pmcs parameter to build_isa_devices_aml().

Added 2016 to all copyrights.

Thanks again for the comments and suggestions.

-corey