From: minyard@acm.org
To: Igor Mammedov <imammedo@redhat.com>,
"Michael S . Tsirkin" <mst@redhat.com>,
Paolo Bonzini <pbonzini@redhat.com>,
qemu-devel@nongnu.org, minyard@acm.org, cminyard@mvista.com
Subject: [Qemu-devel] [PATCH v7 2/6] pc: Postpone SMBIOS table installation to post machine init
Date: Tue, 24 May 2016 12:37:18 -0500 [thread overview]
Message-ID: <1464111442-10387-3-git-send-email-minyard@acm.org> (raw)
In-Reply-To: <1464111442-10387-1-git-send-email-minyard@acm.org>
From: Corey Minyard <cminyard@mvista.com>
This is the same place that the ACPI SSDT table gets added, so that
devices can add themselves to the SMBIOS table.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
hw/i386/pc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index e29ccc8..92125a8 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -765,8 +765,6 @@ static FWCfgState *bochs_bios_init(AddressSpace *as, PCMachineState *pcms)
acpi_tables, acpi_tables_len);
fw_cfg_add_i32(fw_cfg, FW_CFG_IRQ0_OVERRIDE, kvm_allows_irq0_override());
- pc_build_smbios(fw_cfg);
-
fw_cfg_add_bytes(fw_cfg, FW_CFG_E820_TABLE,
&e820_reserve, sizeof(e820_reserve));
fw_cfg_add_file(fw_cfg, "etc/e820", e820_table,
@@ -1182,6 +1180,9 @@ void pc_machine_done(Notifier *notifier, void *data)
}
acpi_setup();
+ if (pcms->fw_cfg) {
+ pc_build_smbios(pcms->fw_cfg);
+ }
}
void pc_guest_info_init(PCMachineState *pcms)
--
2.7.4
next prev parent reply other threads:[~2016-05-24 17:37 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-24 17:37 [Qemu-devel] [PATCH v7 1/6] Add IPMI to firmware tables minyard
2016-05-24 17:37 ` [Qemu-devel] [PATCH v7 1/6] ipmi: rework the fwinfo to be fetched from the interface minyard
2016-05-24 17:37 ` minyard [this message]
2016-05-24 17:37 ` [Qemu-devel] [PATCH v7 3/6] smbios: Move table build tools into an include file minyard
2016-06-03 16:15 ` Michael S. Tsirkin
2016-06-05 4:04 ` Corey Minyard
2016-05-24 17:37 ` [Qemu-devel] [PATCH v7 4/6] ipmi: Add SMBIOS table entry minyard
2016-05-24 17:37 ` [Qemu-devel] [PATCH v7 5/6] acpi: Add IPMI table entries minyard
2016-06-03 16:16 ` Michael S. Tsirkin
2016-05-24 17:37 ` [Qemu-devel] [PATCH v7 6/6] bios: Add tests for the IPMI ACPI and SMBIOS entries minyard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464111442-10387-3-git-send-email-minyard@acm.org \
--to=minyard@acm.org \
--cc=cminyard@mvista.com \
--cc=imammedo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).