From: Gerd Hoffmann <kraxel@redhat.com>
To: Laurent Vivier <lvivier@redhat.com>
Cc: qemu-devel@nongnu.org
Subject: Re: [Qemu-devel] [PATCH] vnc: add configurable keyboard delay
Date: Wed, 25 May 2016 10:25:09 +0200 [thread overview]
Message-ID: <1464164709.13816.5.camel@redhat.com> (raw)
In-Reply-To: <013e4a8b-1725-3722-6c81-c70895e0d628@redhat.com>
Hi,
> > + key_delay_ms = qemu_opt_get_number(opts, "key-delay-ms", 1);
>
> Why the default value is 1 and not 0?
> (Are there some impacts on the "qemu_input_event_send_key_delay(0);" you
> replace above?)
I think it makes sense to have a delay by default, so the guest is
scheduled to run after each event, increasing the chance it picks up the
event. And 1 ms delay is so small that you shouldn't be able to notice
it.
cheers,
Gerd
next prev parent reply other threads:[~2016-05-25 8:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-23 13:19 [Qemu-devel] [PATCH] vnc: add configurable keyboard delay Gerd Hoffmann
2016-05-23 15:00 ` Laurent Vivier
2016-05-23 15:12 ` Laurent Vivier
2016-05-25 8:25 ` Gerd Hoffmann [this message]
2016-05-30 19:59 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464164709.13816.5.camel@redhat.com \
--to=kraxel@redhat.com \
--cc=lvivier@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).