From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:37776) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5U7v-0003zQ-DS for qemu-devel@nongnu.org; Wed, 25 May 2016 04:25:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5U7r-00068E-6O for qemu-devel@nongnu.org; Wed, 25 May 2016 04:25:14 -0400 Received: from mx1.redhat.com ([209.132.183.28]:47942) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5U7r-00067w-0r for qemu-devel@nongnu.org; Wed, 25 May 2016 04:25:11 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 7DD8E7DCC5 for ; Wed, 25 May 2016 08:25:10 +0000 (UTC) Message-ID: <1464164709.13816.5.camel@redhat.com> From: Gerd Hoffmann Date: Wed, 25 May 2016 10:25:09 +0200 In-Reply-To: <013e4a8b-1725-3722-6c81-c70895e0d628@redhat.com> References: <1464009550-6713-1-git-send-email-kraxel@redhat.com> <013e4a8b-1725-3722-6c81-c70895e0d628@redhat.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 Subject: Re: [Qemu-devel] [PATCH] vnc: add configurable keyboard delay List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Laurent Vivier Cc: qemu-devel@nongnu.org Hi, > > + key_delay_ms =3D qemu_opt_get_number(opts, "key-delay-ms", 1); >=20 > Why the default value is 1 and not 0? > (Are there some impacts on the "qemu_input_event_send_key_delay(0);" you > replace above?) I think it makes sense to have a delay by default, so the guest is scheduled to run after each event, increasing the chance it picks up the event. And 1 ms delay is so small that you shouldn't be able to notice it. cheers, Gerd