From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40326) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5W6S-0000Z8-KD for qemu-devel@nongnu.org; Wed, 25 May 2016 06:32:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5W6Q-0002la-3u for qemu-devel@nongnu.org; Wed, 25 May 2016 06:31:51 -0400 Received: from mx1.redhat.com ([209.132.183.28]:40455) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5W6P-0002lU-TY for qemu-devel@nongnu.org; Wed, 25 May 2016 06:31:50 -0400 From: P J P Date: Wed, 25 May 2016 16:01:29 +0530 Message-Id: <1464172291-2856-2-git-send-email-ppandit@redhat.com> In-Reply-To: <1464172291-2856-1-git-send-email-ppandit@redhat.com> References: <1464172291-2856-1-git-send-email-ppandit@redhat.com> Subject: [Qemu-devel] [PATCH 1/3] scsi: megasas: use appropriate property buffer size List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qemu Developers Cc: Paolo Bonzini , Li Qiang , Hannes Reinecke , Alexander Graf , Prasad J Pandit From: Prasad J Pandit When setting MegaRAID SAS controller properties via MegaRAID Firmware Interface(MFI) commands, a user supplied size parameter is used to set property value. Use appropriate size value to avoid OOB access issues. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index a63a581..dcbd3e1 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -1446,7 +1446,7 @@ static int megasas_dcmd_set_properties(MegasasState *s, MegasasCmd *cmd) dcmd_size); return MFI_STAT_INVALID_PARAMETER; } - dma_buf_write((uint8_t *)&info, cmd->iov_size, &cmd->qsg); + dma_buf_write((uint8_t *)&info, dcmd_size, &cmd->qsg); trace_megasas_dcmd_unsupported(cmd->index, cmd->iov_size); return MFI_STAT_OK; } -- 2.5.5