From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:40635) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5W6e-0000k9-Vm for qemu-devel@nongnu.org; Wed, 25 May 2016 06:32:14 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5W6V-0002pg-N4 for qemu-devel@nongnu.org; Wed, 25 May 2016 06:32:03 -0400 Received: from mx1.redhat.com ([209.132.183.28]:51635) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5W6V-0002pT-IO for qemu-devel@nongnu.org; Wed, 25 May 2016 06:31:55 -0400 From: P J P Date: Wed, 25 May 2016 16:01:30 +0530 Message-Id: <1464172291-2856-3-git-send-email-ppandit@redhat.com> In-Reply-To: <1464172291-2856-1-git-send-email-ppandit@redhat.com> References: <1464172291-2856-1-git-send-email-ppandit@redhat.com> Subject: [Qemu-devel] [PATCH 2/3] scsi: megasas: initialise local configuration data buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qemu Developers Cc: Paolo Bonzini , Li Qiang , Hannes Reinecke , Alexander Graf , Prasad J Pandit From: Prasad J Pandit When reading MegaRAID SAS controller configuration via MegaRAID Firmware Interface(MFI) commands, routine megasas_dcmd_cfg_read uses an uninitialised local data buffer. Initialise this buffer to avoid stack information leakage. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/scsi/megasas.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index dcbd3e1..7c08932 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -1305,6 +1305,7 @@ static int megasas_dcmd_cfg_read(MegasasState *s, MegasasCmd *cmd) QTAILQ_FOREACH(kid, &s->bus.qbus.children, sibling) { num_pd_disks++; } + memset(data, 0, sizeof(data)); info = (struct mfi_config_data *)&data; /* * Array mapping: -- 2.5.5