From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:42564) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5XfM-00066E-QR for qemu-devel@nongnu.org; Wed, 25 May 2016 08:12:01 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b5XfI-0004RC-LR for qemu-devel@nongnu.org; Wed, 25 May 2016 08:12:00 -0400 Received: from mx1.redhat.com ([209.132.183.28]:46217) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b5XfI-0004R4-GM for qemu-devel@nongnu.org; Wed, 25 May 2016 08:11:56 -0400 From: P J P Date: Wed, 25 May 2016 17:41:44 +0530 Message-Id: <1464178304-12831-1-git-send-email-ppandit@redhat.com> Subject: [Qemu-devel] [PATCH v2] scsi: megasas: initialise local configuration data buffer List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Qemu Developers Cc: Paolo Bonzini , Li Qiang , Hannes Reinecke , Alexander Graf , Prasad J Pandit From: Prasad J Pandit When reading MegaRAID SAS controller configuration via MegaRAID Firmware Interface(MFI) commands, routine megasas_dcmd_cfg_read uses an uninitialised local data buffer. Initialise this buffer to avoid stack information leakage. Reported-by: Li Qiang Signed-off-by: Prasad J Pandit --- hw/scsi/megasas.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Update as per -> https://lists.gnu.org/archive/html/qemu-devel/2016-05/msg04402.html diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index dcbd3e1..bf642d4 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -1293,7 +1293,7 @@ static int megasas_dcmd_ld_get_info(MegasasState *s, MegasasCmd *cmd) static int megasas_dcmd_cfg_read(MegasasState *s, MegasasCmd *cmd) { - uint8_t data[4096]; + uint8_t data[4096] = { 0 }; struct mfi_config_data *info; int num_pd_disks = 0, array_offset, ld_offset; BusChild *kid; -- 2.5.5