qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Steven Luo <steven@steven676.net>
To: qemu-devel@nongnu.org
Cc: "Daniel P. Berrange" <berrange@redhat.com>,
	qemu-trivial@nongnu.org, qemu-stable@nongnu.org
Subject: [Qemu-devel] [PATCH] Fix configure test for PBKDF2 in nettle
Date: Thu, 26 May 2016 21:53:13 -0700	[thread overview]
Message-ID: <1464324793-29101-1-git-send-email-steven@steven676.net> (raw)

From: Steven Luo <steven+qemu@steven676.net>

On my Debian jessie system, including nettle/pbkdf2.h does not cause
NULL to be defined, which causes the test to fail to compile.  Include
stddef.h to bring in a definition of NULL.

Cc: qemu-trivial@nongnu.org
Cc: qemu-stable@nongnu.org
Signed-off-by: Steven Luo <steven+qemu@steven676.net>
---
I suppose this could also be fixed by defining NULL ourselves, or by
replacing NULLs with 0s -- if one of those other approaches is
preferred, let me know.

 configure | 1 +
 1 file changed, 1 insertion(+)

diff --git a/configure b/configure
index c37fc5f..0aae017 100755
--- a/configure
+++ b/configure
@@ -2342,6 +2342,7 @@ if test "$nettle" != "no"; then
         nettle="yes"
 
         cat > $TMPC << EOF
+#include <stddef.h>
 #include <nettle/pbkdf2.h>
 int main(void) {
      pbkdf2_hmac_sha256(8, NULL, 1000, 8, NULL, 8, NULL);
-- 
2.1.4

             reply	other threads:[~2016-05-27  4:53 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-27  4:53 Steven Luo [this message]
2016-05-29  8:40 ` [Qemu-devel] [PATCH] Fix configure test for PBKDF2 in nettle Michael Tokarev
2016-05-31  9:23 ` Daniel P. Berrange

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464324793-29101-1-git-send-email-steven@steven676.net \
    --to=steven@steven676.net \
    --cc=berrange@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-stable@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).