From: Peter Maydell <peter.maydell@linaro.org>
To: qemu-devel@nongnu.org
Cc: patches@linaro.org, Riku Voipio <riku.voipio@iki.fi>,
Timothy Edward Baldwin <T.E.Baldwin99@members.leeds.ac.uk>
Subject: [Qemu-devel] [PATCH v2 05/19] linux-user: Define macro for size of host kernel sigset_t
Date: Fri, 27 May 2016 15:51:47 +0100 [thread overview]
Message-ID: <1464360721-14359-6-git-send-email-peter.maydell@linaro.org> (raw)
In-Reply-To: <1464360721-14359-1-git-send-email-peter.maydell@linaro.org>
Some host syscalls take an argument specifying the size of a
host kernel's sigset_t (which isn't necessarily the same as
that of the host libc's type of that name). Instead of hardcoding
_NSIG / 8 where we do this, define and use a SIGSET_T_SIZE macro.
Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
linux-user/syscall.c | 9 +++++++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/linux-user/syscall.c b/linux-user/syscall.c
index df70255..e4b7404 100644
--- a/linux-user/syscall.c
+++ b/linux-user/syscall.c
@@ -119,6 +119,10 @@ int __clone2(int (*fn)(void *), void *child_stack_base,
#define VFAT_IOCTL_READDIR_BOTH _IOR('r', 1, struct linux_dirent [2])
#define VFAT_IOCTL_READDIR_SHORT _IOR('r', 2, struct linux_dirent [2])
+/* This is the size of the host kernel's sigset_t, needed where we make
+ * direct system calls that take a sigset_t pointer and a size.
+ */
+#define SIGSET_T_SIZE (_NSIG / 8)
#undef _syscall0
#undef _syscall1
@@ -7221,7 +7225,7 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
/* Extract the two packed args for the sigset */
if (arg6) {
sig_ptr = &sig;
- sig.size = _NSIG / 8;
+ sig.size = SIGSET_T_SIZE;
arg7 = lock_user(VERIFY_READ, arg6, sizeof(*arg7) * 2, 1);
if (!arg7) {
@@ -8275,7 +8279,8 @@ abi_long do_syscall(void *cpu_env, int num, abi_long arg1,
set = NULL;
}
- ret = get_errno(sys_ppoll(pfd, nfds, timeout_ts, set, _NSIG/8));
+ ret = get_errno(sys_ppoll(pfd, nfds, timeout_ts,
+ set, SIGSET_T_SIZE));
if (!is_error(ret) && arg3) {
host_to_target_timespec(arg3, timeout_ts);
--
1.9.1
next prev parent reply other threads:[~2016-05-27 14:55 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-27 14:51 [Qemu-devel] [PATCH v2 00/19] linux-user: fix various signal race conditions Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 01/19] linux-user: Factor out handle_signal code from process_pending_signals() Peter Maydell
2016-06-06 21:42 ` Laurent Vivier
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 02/19] linux-user: Move handle_pending_signal() to avoid need for declaration Peter Maydell
2016-06-06 21:42 ` Laurent Vivier
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 03/19] linux-user: Fix stray tab-indent Peter Maydell
2016-06-06 21:43 ` Laurent Vivier
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 04/19] linux-user: Factor out uses of do_sigprocmask() from sigreturn code Peter Maydell
2016-06-06 21:46 ` Laurent Vivier
2016-05-27 14:51 ` Peter Maydell [this message]
2016-06-06 21:47 ` [Qemu-devel] [PATCH v2 05/19] linux-user: Define macro for size of host kernel sigset_t Laurent Vivier
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 06/19] linux-user: Use safe_syscall for sigsuspend syscalls Peter Maydell
2016-06-07 7:20 ` Laurent Vivier
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 07/19] linux-user: Fix race between multiple signals Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 08/19] linux-user: Remove redundant default action check in queue_signal() Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 09/19] linux-user: Remove redundant gdb_queuesig() Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 10/19] linux-user: Remove real-time signal queuing Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 11/19] linux-user: Queue synchronous signals separately Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 12/19] linux-user: Block signals during sigaction() handling Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 13/19] linux-user: pause() should not pause if signal pending Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 14/19] linux-user: Restart exit() " Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 15/19] linux-user: Use safe_syscall for kill, tkill and tgkill syscalls Peter Maydell
2016-06-07 7:43 ` Laurent Vivier
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 16/19] linux-user: Restart fork() if signals pending Peter Maydell
2016-05-27 14:51 ` [Qemu-devel] [PATCH v2 17/19] linux-user: Use both si_code and si_signo when converting siginfo_t Peter Maydell
2016-06-07 19:22 ` Laurent Vivier
2016-06-07 21:06 ` Peter Maydell
2016-06-08 6:30 ` Riku Voipio
2016-06-08 7:11 ` Riku Voipio
2016-06-09 13:19 ` Peter Maydell
2016-05-27 14:52 ` [Qemu-devel] [PATCH v2 18/19] linux-user: Avoid possible misalignment in host_to_target_siginfo() Peter Maydell
2016-06-07 19:36 ` Laurent Vivier
2016-06-07 21:08 ` Peter Maydell
2016-06-08 9:29 ` Laurent Vivier
2016-06-08 11:29 ` Peter Maydell
2016-05-27 14:52 ` [Qemu-devel] [PATCH v2 19/19] linux-user: Avoid possible misalignment in target_to_host_siginfo() Peter Maydell
2016-06-07 19:40 ` Laurent Vivier
2016-06-06 14:42 ` [Qemu-devel] [PATCH v2 00/19] linux-user: fix various signal race conditions Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464360721-14359-6-git-send-email-peter.maydell@linaro.org \
--to=peter.maydell@linaro.org \
--cc=T.E.Baldwin99@members.leeds.ac.uk \
--cc=patches@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=riku.voipio@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).