From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:38405) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6uLx-0001X8-Rm for qemu-devel@nongnu.org; Sun, 29 May 2016 02:37:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b6uLt-0003wB-LG for qemu-devel@nongnu.org; Sun, 29 May 2016 02:37:36 -0400 Received: from mail-wm0-x244.google.com ([2a00:1450:400c:c09::244]:36556) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b6uLt-0003w7-Dk for qemu-devel@nongnu.org; Sun, 29 May 2016 02:37:33 -0400 Received: by mail-wm0-x244.google.com with SMTP id q62so12450111wmg.3 for ; Sat, 28 May 2016 23:37:32 -0700 (PDT) From: Sameeh Jubran Date: Sun, 29 May 2016 09:37:25 +0300 Message-Id: <1464503845-29545-1-git-send-email-sameeh@daynix.com> Subject: [Qemu-devel] [PATCH] e1000: Removing unnecessary if statement List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, Jason Wang Cc: Dmitry Fleytman , Yan Vugenfirer Since mit_delay can never be 0 this if statement is superfluous. Signed-off-by: Sameeh Jubran --- hw/net/e1000.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/hw/net/e1000.c b/hw/net/e1000.c index 8e79b55..eb903a9 100644 --- a/hw/net/e1000.c +++ b/hw/net/e1000.c @@ -365,11 +365,9 @@ set_interrupt_cause(E1000State *s, int index, uint32_t val) */ mit_delay = (mit_delay < 500) ? 500 : mit_delay; - if (mit_delay) { - s->mit_timer_on = 1; - timer_mod(s->mit_timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + - mit_delay * 256); - } + s->mit_timer_on = 1; + timer_mod(s->mit_timer, qemu_clock_get_ns(QEMU_CLOCK_VIRTUAL) + + mit_delay * 256); s->mit_ide = 0; } } -- 2.5.5