qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Peter Xu <peterx@redhat.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com,
	jasowang@redhat.com, marcel@redhat.com, mst@redhat.com,
	pbonzini@redhat.com, jan.kiszka@web.de, rkrcmar@redhat.com,
	alex.williamson@redhat.com, wexu@redhat.com,
	davidkiarie4@gmail.com, peterx@redhat.com
Subject: [Qemu-devel] [PATCH v8 25/25] intel_iommu: support all masks in interrupt entry cache invalidation
Date: Mon, 30 May 2016 18:31:38 +0800	[thread overview]
Message-ID: <1464604298-16739-26-git-send-email-peterx@redhat.com> (raw)
In-Reply-To: <1464604298-16739-1-git-send-email-peterx@redhat.com>

From: Radim Krčmář <rkrcmar@redhat.com>

Linux guests do not gracefully handle cases when the invalidation mask
they wanted is not supported, probably because real hardware always
allowed all.

We can just say that all 16 masks are supported, because both
ioapic_iec_notifier and kvm_update_msi_routes_all invalidate all caches.

Signed-off-by: Radim Krčmář <rkrcmar@redhat.com>
---
 hw/i386/intel_iommu.c          | 2 +-
 hw/i386/intel_iommu_internal.h | 1 +
 2 files changed, 2 insertions(+), 1 deletion(-)

diff --git a/hw/i386/intel_iommu.c b/hw/i386/intel_iommu.c
index c4ea0c3..d0c9743 100644
--- a/hw/i386/intel_iommu.c
+++ b/hw/i386/intel_iommu.c
@@ -2354,7 +2354,7 @@ static void vtd_init(IntelIOMMUState *s)
     s->ecap = VTD_ECAP_QI | VTD_ECAP_IRO;
 
     if (ms->iommu_intr) {
-        s->ecap |= VTD_ECAP_IR | VTD_ECAP_EIM;
+        s->ecap |= VTD_ECAP_IR | VTD_ECAP_EIM | VTD_ECAP_MHMV;
     }
 
     vtd_reset_context_cache(s);
diff --git a/hw/i386/intel_iommu_internal.h b/hw/i386/intel_iommu_internal.h
index 72b0114..0829a50 100644
--- a/hw/i386/intel_iommu_internal.h
+++ b/hw/i386/intel_iommu_internal.h
@@ -186,6 +186,7 @@
 /* Interrupt Remapping support */
 #define VTD_ECAP_IR                 (1ULL << 3)
 #define VTD_ECAP_EIM                (1ULL << 4)
+#define VTD_ECAP_MHMV               (15ULL << 20)
 
 /* CAP_REG */
 /* (offset >> 4) << 24 */
-- 
2.4.11

  parent reply	other threads:[~2016-05-30 10:33 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-30 10:31 [Qemu-devel] [PATCH v8 00/25] IOMMU: Enable interrupt remapping for Intel IOMMU Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 01/25] acpi: enable INTR for DMAR report structure Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 02/25] intel_iommu: allow queued invalidation for IR Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 03/25] intel_iommu: set IR bit for ECAP register Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 04/25] acpi: add DMAR scope definition for root IOAPIC Peter Xu
2016-06-01 12:56   ` Igor Mammedov
2016-06-02  4:16     ` Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 05/25] intel_iommu: define interrupt remap table addr register Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 06/25] intel_iommu: handle interrupt remap enable Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 07/25] intel_iommu: define several structs for IOMMU IR Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 08/25] x86-iommu: introduce parent class Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 09/25] x86-iommu: provide x86_iommu_get_default Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 10/25] x86-iommu: q35: generalize find_add_as() Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 11/25] intel_iommu: add IR translation faults defines Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 12/25] intel_iommu: Add support for PCI MSI remap Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 13/25] q35: ioapic: add support for emulated IOAPIC IR Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 14/25] ioapic: introduce ioapic_entry_parse() helper Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 15/25] intel_iommu: add support for split irqchip Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 16/25] q35: add "intremap" parameter to enable IR Peter Xu
2016-05-30 12:43   ` Jan Kiszka
2016-05-30 13:33     ` Peter Xu
2016-06-02  9:21       ` Marcel Apfelbaum
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 17/25] x86-iommu: introduce IEC notifiers Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 18/25] ioapic: register IOMMU IEC notifier for ioapic Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 19/25] intel_iommu: Add support for Extended Interrupt Mode Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 20/25] intel_iommu: add SID validation for IR Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 21/25] kvm-irqchip: simplify kvm_irqchip_add_msi_route Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 22/25] kvm-irqchip: i386: add hook for add/remove virq Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 23/25] kvm-irqchip: x86: add msi route notify fn Peter Xu
2016-05-30 10:31 ` [Qemu-devel] [PATCH v8 24/25] kvm-irqchip: do explicit commit when update irq Peter Xu
2016-05-30 10:31 ` Peter Xu [this message]
2016-05-30 10:38 ` [Qemu-devel] [PATCH v8 00/25] IOMMU: Enable interrupt remapping for Intel IOMMU Peter Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464604298-16739-26-git-send-email-peterx@redhat.com \
    --to=peterx@redhat.com \
    --cc=alex.williamson@redhat.com \
    --cc=davidkiarie4@gmail.com \
    --cc=ehabkost@redhat.com \
    --cc=imammedo@redhat.com \
    --cc=jan.kiszka@web.de \
    --cc=jasowang@redhat.com \
    --cc=marcel@redhat.com \
    --cc=mst@redhat.com \
    --cc=pbonzini@redhat.com \
    --cc=qemu-devel@nongnu.org \
    --cc=rkrcmar@redhat.com \
    --cc=rth@twiddle.net \
    --cc=wexu@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).