From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50049) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Lri-0003n0-Tg for qemu-devel@nongnu.org; Mon, 30 May 2016 08:00:15 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7Lrc-00084N-H3 for qemu-devel@nongnu.org; Mon, 30 May 2016 08:00:13 -0400 Received: from mx-v6.kamp.de ([2a02:248:0:51::16]:58542 helo=mx01.kamp.de) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7Lrc-00080o-7C for qemu-devel@nongnu.org; Mon, 30 May 2016 08:00:08 -0400 From: Peter Lieven Date: Mon, 30 May 2016 13:59:59 +0200 Message-Id: <1464609599-7495-1-git-send-email-pl@kamp.de> Subject: [Qemu-devel] [PATCH] block: assert that bs->request_alignment is a power of 2 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-block@nongnu.org Cc: qemu-devel@nongnu.org, kwolf@redhat.com, mreitz@redhat.com, Peter Lieven at least bdrv_co_preadv/pwritev expect this. Signed-off-by: Peter Lieven --- block.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block.c b/block.c index 736432f..f54bc25 100644 --- a/block.c +++ b/block.c @@ -1018,7 +1018,7 @@ static int bdrv_open_common(BlockDriverState *bs, BdrvChild *file, assert(bdrv_opt_mem_align(bs) != 0); assert(bdrv_min_mem_align(bs) != 0); - assert((bs->request_alignment != 0) || bdrv_is_sg(bs)); + assert(is_power_of_2(bs->request_alignment) || bdrv_is_sg(bs)); qemu_opts_del(opts); return 0; -- 1.9.1