From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56138) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7f5W-00015T-7s for qemu-devel@nongnu.org; Tue, 31 May 2016 04:31:47 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b7f5R-0004dn-FO for qemu-devel@nongnu.org; Tue, 31 May 2016 04:31:46 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39704) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b7f5R-0004dg-9h for qemu-devel@nongnu.org; Tue, 31 May 2016 04:31:41 -0400 Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id BD058BDEE for ; Tue, 31 May 2016 08:31:40 +0000 (UTC) From: Markus Armbruster Date: Tue, 31 May 2016 10:31:38 +0200 Message-Id: <1464683498-28779-1-git-send-email-armbru@redhat.com> Subject: [Qemu-devel] [PATCH] vl: Error messages need to go to stderr, fix some List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org, pbonzini@redhat.com We print a few fatal error messages to stdout instead of stderr. Reproducer: $ qemu-system-x86_64 -g 1024x768 Option g not supported for this target $ qemu-system-x86_64 -g 1024x768 >/dev/null Fix by printing them with error_report(). This also improves the messages. The above one becomes qemu-system-x86_64: -g 1024x768: Option not supported for this target Reported-by: Tobi {github.com/tobimensch} Signed-off-by: Markus Armbruster --- vl.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/vl.c b/vl.c index 18d1423..7800b31 100644 --- a/vl.c +++ b/vl.c @@ -3075,7 +3075,7 @@ int main(int argc, char **argv, char **envp) popt = lookup_opt(argc, argv, &optarg, &optind); if (!(popt->arch_mask & arch_type)) { - printf("Option %s not supported for this target\n", popt->name); + error_report("Option not supported for this target"); exit(1); } switch(popt->index) { @@ -3849,21 +3849,21 @@ int main(int argc, char **argv, char **envp) break; case QEMU_OPTION_xen_domid: if (!(xen_available())) { - printf("Option %s not supported for this target\n", popt->name); + error_report("Option not supported for this target"); exit(1); } xen_domid = atoi(optarg); break; case QEMU_OPTION_xen_create: if (!(xen_available())) { - printf("Option %s not supported for this target\n", popt->name); + error_report("Option not supported for this target"); exit(1); } xen_mode = XEN_CREATE; break; case QEMU_OPTION_xen_attach: if (!(xen_available())) { - printf("Option %s not supported for this target\n", popt->name); + error_report("Option not supported for this target"); exit(1); } xen_mode = XEN_ATTACH; -- 2.5.5