From: "Cédric Le Goater" <clg@kaod.org>
To: Eric Blake <eblake@redhat.com>
Cc: "Peter Crosthwaite" <crosthwaite.peter@gmail.com>,
"Kevin Wolf" <kwolf@redhat.com>, "Max Reitz" <mreitz@redhat.com>,
qemu-block@nongnu.org, qemu-devel@nongnu.org,
"Cédric Le Goater" <clg@kaod.org>
Subject: [Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value
Date: Tue, 31 May 2016 13:36:05 +0200 [thread overview]
Message-ID: <1464694565-16784-1-git-send-email-clg@kaod.org> (raw)
commit 243e6f69c129 ("m25p80: Switch to byte-based block access")
replaced blk_read() calls with blk_pread() but return values are
different.
Signed-off-by: Cédric Le Goater <clg@kaod.org>
---
hw/block/m25p80.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: qemu-ast2400-mainline.git/hw/block/m25p80.c
===================================================================
--- qemu-ast2400-mainline.git.orig/hw/block/m25p80.c
+++ qemu-ast2400-mainline.git/hw/block/m25p80.c
@@ -900,7 +900,7 @@ static int m25p80_init(SSISlave *ss)
s->storage = blk_blockalign(s->blk, s->size);
/* FIXME: Move to late init */
- if (blk_pread(s->blk, 0, s->storage, s->size)) {
+ if (blk_pread(s->blk, 0, s->storage, s->size) != s->size) {
fprintf(stderr, "Failed to initialize SPI flash!\n");
return 1;
}
next reply other threads:[~2016-05-31 11:36 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 11:36 Cédric Le Goater [this message]
2016-05-31 14:26 ` [Qemu-devel] [PATCH] m25p80: fix test on blk_pread() return value Eric Blake
2016-05-31 14:29 ` Cédric Le Goater
2016-05-31 14:36 ` Eric Blake
2016-06-13 16:25 ` Cédric Le Goater
2016-06-13 16:47 ` Eric Blake
2016-06-13 17:43 ` Cédric Le Goater
2016-06-13 18:56 ` Eric Blake
2016-06-14 8:02 ` Cédric Le Goater
2016-06-14 8:38 ` Kevin Wolf
2016-06-14 16:02 ` Cédric Le Goater
2016-06-15 7:57 ` Kevin Wolf
2016-06-15 13:36 ` Cédric Le Goater
2016-06-15 17:03 ` Cédric Le Goater
2016-06-14 8:54 ` Kevin Wolf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464694565-16784-1-git-send-email-clg@kaod.org \
--to=clg@kaod.org \
--cc=crosthwaite.peter@gmail.com \
--cc=eblake@redhat.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).