qemu-devel.nongnu.org archive mirror
 help / color / mirror / Atom feed
From: Laurent Vivier <lvivier@redhat.com>
To: qemu-trivial@nongnu.org, qemu-devel@nongnu.org
Cc: Laurent Vivier <lvivier@redhat.com>, qemu-block@nongnu.org
Subject: [Qemu-devel] [PATCH 05/16] block: Use DIV_ROUND_UP
Date: Tue, 31 May 2016 18:35:54 +0200	[thread overview]
Message-ID: <1464712565-14857-6-git-send-email-lvivier@redhat.com> (raw)
In-Reply-To: <1464712565-14857-1-git-send-email-lvivier@redhat.com>

Replace (((n) + (d) - 1) /(d)) by DIV_ROUND_UP(n,d).

This patch is the result of coccinelle script
scripts/coccinelle/round.cocci

CC: qemu-block@nongnu.org
Signed-off-by: Laurent Vivier <lvivier@redhat.com>
---
 block/vvfat.c      | 3 +--
 hw/block/tc58128.c | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)

diff --git a/block/vvfat.c b/block/vvfat.c
index a39dbe6..6d2e21c 100644
--- a/block/vvfat.c
+++ b/block/vvfat.c
@@ -1960,8 +1960,7 @@ DLOG(fprintf(stderr, "check direntry %d:\n", i); print_direntry(direntries + i))
 		/* check file size with FAT */
 		cluster_count = get_cluster_count_for_direntry(s, direntries + i, path2);
 		if (cluster_count !=
-			(le32_to_cpu(direntries[i].size) + s->cluster_size
-			 - 1) / s->cluster_size) {
+            DIV_ROUND_UP(le32_to_cpu(direntries[i].size), s->cluster_size)) {
 		    DLOG(fprintf(stderr, "Cluster count mismatch\n"));
 		    goto fail;
 		}
diff --git a/hw/block/tc58128.c b/hw/block/tc58128.c
index 7909d50..1d9f7ee 100644
--- a/hw/block/tc58128.c
+++ b/hw/block/tc58128.c
@@ -45,7 +45,7 @@ static void init_dev(tc58128_dev * dev, const char *filename)
             }
 	} else {
 	    /* Build first block with number of blocks */
-	    blocks = (ret + 528 * 32 - 1) / (528 * 32);
+            blocks = DIV_ROUND_UP(ret, 528 * 32);
 	    dev->flash_contents[0] = blocks & 0xff;
 	    dev->flash_contents[1] = (blocks >> 8) & 0xff;
 	    dev->flash_contents[2] = (blocks >> 16) & 0xff;
-- 
2.5.5

  parent reply	other threads:[~2016-05-31 16:36 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-05-31 16:35 [Qemu-devel] [PATCH 00/16] use macro DIV_ROUND_UP instead of (((n) + (d) - 1) /(d)) Laurent Vivier
2016-05-31 16:35 ` [Qemu-devel] [PATCH 01/16] coccinelle: " Laurent Vivier
2016-05-31 17:12   ` Eric Blake
2016-05-31 17:24     ` Laurent Vivier
2016-05-31 16:35 ` [Qemu-devel] [PATCH 02/16] parallels: Use DIV_ROUND_UP Laurent Vivier
2016-05-31 17:18   ` Eric Blake
2016-05-31 16:35 ` [Qemu-devel] [PATCH 03/16] qcow/qcow2: " Laurent Vivier
2016-05-31 17:20   ` Eric Blake
2016-05-31 16:35 ` [Qemu-devel] [PATCH 04/16] qed: " Laurent Vivier
2016-05-31 17:49   ` Eric Blake
2016-05-31 16:35 ` Laurent Vivier [this message]
2016-05-31 17:50   ` [Qemu-devel] [PATCH 05/16] block: " Eric Blake
2016-05-31 16:35 ` [Qemu-devel] [PATCH 06/16] crypto: " Laurent Vivier
2016-05-31 16:45   ` Daniel P. Berrange
2016-05-31 16:35 ` [Qemu-devel] [PATCH 07/16] xen: " Laurent Vivier
2016-06-01  9:33   ` Stefano Stabellini
2016-05-31 16:35 ` [Qemu-devel] [PATCH 08/16] audio: " Laurent Vivier
2016-05-31 16:35 ` [Qemu-devel] [PATCH 09/16] SPICE: " Laurent Vivier
2016-05-31 16:35 ` [Qemu-devel] [PATCH 10/16] rocker: " Laurent Vivier
2016-05-31 16:36 ` [Qemu-devel] [PATCH 11/16] usb: " Laurent Vivier
2016-05-31 16:36 ` [Qemu-devel] [PATCH 12/16] slirp: " Laurent Vivier
2016-05-31 16:41   ` Samuel Thibault
2016-05-31 16:36 ` [Qemu-devel] [PATCH 13/16] linux-user: " Laurent Vivier
2016-05-31 16:36 ` [Qemu-devel] [PATCH 14/16] pc-bios/s390-ccw: " Laurent Vivier
2016-05-31 16:36 ` [Qemu-devel] [PATCH 15/16] qemu-timer: " Laurent Vivier
2016-05-31 16:36 ` [Qemu-devel] [PATCH 16/16] hbitmap: " Laurent Vivier
2016-06-03 18:17   ` John Snow
2016-06-05  7:16 ` [Qemu-devel] [PATCH 00/16] use macro DIV_ROUND_UP instead of (((n) + (d) - 1) /(d)) Michael Tokarev

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1464712565-14857-6-git-send-email-lvivier@redhat.com \
    --to=lvivier@redhat.com \
    --cc=qemu-block@nongnu.org \
    --cc=qemu-devel@nongnu.org \
    --cc=qemu-trivial@nongnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).