From: Eric Blake <eblake@redhat.com>
To: qemu-devel@nongnu.org
Cc: armbru@redhat.com
Subject: [Qemu-devel] [PATCH v2 0/3] Fix leak in handling of integer lists as strings
Date: Tue, 31 May 2016 10:41:27 -0600 [thread overview]
Message-ID: <1464712890-14262-1-git-send-email-eblake@redhat.com> (raw)
The qapi string-input and string-output visitors can leak memory
when used on integer lists that were set up such that the range
list needed to merge adjacent/overlapping ranges; detected by
valgrind on test-string-{input,output}-visitor.
It doesn't hurt that the overall series removes more code than it adds
(modulo copyright blurbs)
v2:
- split out new patch 1 util/range.c, to make code motion easier to follow
- address review comments from Markus
Eric Blake (3):
range: Create range.c for code that should not be inline
qapi: Simplify use of range.h
qapi: Fix memleak in string visitors on int lists
include/qemu/range.h | 91 ++++++++++----------------------------------
qapi/string-input-visitor.c | 17 ++-------
qapi/string-output-visitor.c | 4 +-
util/range.c | 76 ++++++++++++++++++++++++++++++++++++
util/Makefile.objs | 1 +
5 files changed, 104 insertions(+), 85 deletions(-)
create mode 100644 util/range.c
--
2.5.5
next reply other threads:[~2016-05-31 16:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-31 16:41 Eric Blake [this message]
2016-05-31 16:41 ` [Qemu-devel] [PATCH v2 1/3] range: Create range.c for code that should not be inline Eric Blake
2016-05-31 16:41 ` [Qemu-devel] [PATCH v2 2/3] qapi: Simplify use of range.h Eric Blake
2016-05-31 16:41 ` [Qemu-devel] [PATCH v2 3/3] qapi: Fix memleak in string visitors on int lists Eric Blake
2016-06-01 7:47 ` Markus Armbruster
2016-06-01 14:51 ` Eric Blake
2016-06-13 12:54 ` Markus Armbruster
2016-06-14 17:53 ` Markus Armbruster
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464712890-14262-1-git-send-email-eblake@redhat.com \
--to=eblake@redhat.com \
--cc=armbru@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).