* [Qemu-devel] [PATCH] host-utils: Prefer 'false' for bool type
@ 2016-05-31 18:33 Eric Blake
2016-06-01 8:04 ` Michael Tokarev
0 siblings, 1 reply; 2+ messages in thread
From: Eric Blake @ 2016-05-31 18:33 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-trivial
Mixing '0' and 'bool' looks stupid.
Signed-off-by: Eric Blake <eblake@redhat.com>
---
include/qemu/host-utils.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/qemu/host-utils.h b/include/qemu/host-utils.h
index 1cdae0d..3de7d4e 100644
--- a/include/qemu/host-utils.h
+++ b/include/qemu/host-utils.h
@@ -486,7 +486,7 @@ static inline uint64_t revbit64(uint64_t x)
static inline bool is_power_of_2(uint64_t value)
{
if (!value) {
- return 0;
+ return false;
}
return !(value & (value - 1));
--
2.5.5
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [Qemu-devel] [PATCH] host-utils: Prefer 'false' for bool type
2016-05-31 18:33 [Qemu-devel] [PATCH] host-utils: Prefer 'false' for bool type Eric Blake
@ 2016-06-01 8:04 ` Michael Tokarev
0 siblings, 0 replies; 2+ messages in thread
From: Michael Tokarev @ 2016-06-01 8:04 UTC (permalink / raw)
To: Eric Blake, qemu-devel; +Cc: qemu-trivial
31.05.2016 21:33, Eric Blake wrote:
> Mixing '0' and 'bool' looks stupid.
Applied to -trivial, thanks!
/mjt
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-06-01 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-05-31 18:33 [Qemu-devel] [PATCH] host-utils: Prefer 'false' for bool type Eric Blake
2016-06-01 8:04 ` Michael Tokarev
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).