* [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include
@ 2016-06-01 2:23 Fam Zheng
2016-06-14 22:05 ` Eric Blake
0 siblings, 1 reply; 4+ messages in thread
From: Fam Zheng @ 2016-06-01 2:23 UTC (permalink / raw)
To: qemu-devel; +Cc: Paolo Bonzini
The file is only included from the top Makefile. Rename it to reflect
this more obviously.
Signed-off-by: Fam Zheng <famz@redhat.com>
---
Makefile | 2 +-
tests/{Makefile => Makefile.include} | 0
2 files changed, 1 insertion(+), 1 deletion(-)
rename tests/{Makefile => Makefile.include} (100%)
diff --git a/Makefile b/Makefile
index 3a3c5dc..0cd111b 100644
--- a/Makefile
+++ b/Makefile
@@ -161,7 +161,7 @@ dummy := $(call unnest-vars,, \
common-obj-m)
ifneq ($(wildcard config-host.mak),)
-include $(SRC_PATH)/tests/Makefile
+include $(SRC_PATH)/tests/Makefile.include
endif
all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all modules
diff --git a/tests/Makefile b/tests/Makefile.include
similarity index 100%
rename from tests/Makefile
rename to tests/Makefile.include
--
2.8.2
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include
2016-06-01 2:23 [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include Fam Zheng
@ 2016-06-14 22:05 ` Eric Blake
2016-06-15 0:33 ` Fam Zheng
0 siblings, 1 reply; 4+ messages in thread
From: Eric Blake @ 2016-06-14 22:05 UTC (permalink / raw)
To: Fam Zheng, qemu-devel; +Cc: Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 1110 bytes --]
On 05/31/2016 08:23 PM, Fam Zheng wrote:
> The file is only included from the top Makefile. Rename it to reflect
> this more obviously.
>
> Signed-off-by: Fam Zheng <famz@redhat.com>
> ---
> Makefile | 2 +-
> tests/{Makefile => Makefile.include} | 0
> 2 files changed, 1 insertion(+), 1 deletion(-)
> rename tests/{Makefile => Makefile.include} (100%)
Reviewed-by: Eric Blake <eblake@redhat.com>
>
> diff --git a/Makefile b/Makefile
> index 3a3c5dc..0cd111b 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -161,7 +161,7 @@ dummy := $(call unnest-vars,, \
> common-obj-m)
>
> ifneq ($(wildcard config-host.mak),)
> -include $(SRC_PATH)/tests/Makefile
> +include $(SRC_PATH)/tests/Makefile.include
> endif
>
> all: $(DOCS) $(TOOLS) $(HELPERS-y) recurse-all modules
> diff --git a/tests/Makefile b/tests/Makefile.include
> similarity index 100%
> rename from tests/Makefile
> rename to tests/Makefile.include
>
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include
2016-06-14 22:05 ` Eric Blake
@ 2016-06-15 0:33 ` Fam Zheng
2016-06-15 1:41 ` Eric Blake
0 siblings, 1 reply; 4+ messages in thread
From: Fam Zheng @ 2016-06-15 0:33 UTC (permalink / raw)
To: Eric Blake; +Cc: qemu-devel, Paolo Bonzini
On Tue, 06/14 16:05, Eric Blake wrote:
> On 05/31/2016 08:23 PM, Fam Zheng wrote:
> > The file is only included from the top Makefile. Rename it to reflect
> > this more obviously.
> >
> > Signed-off-by: Fam Zheng <famz@redhat.com>
> > ---
> > Makefile | 2 +-
> > tests/{Makefile => Makefile.include} | 0
> > 2 files changed, 1 insertion(+), 1 deletion(-)
> > rename tests/{Makefile => Makefile.include} (100%)
>
> Reviewed-by: Eric Blake <eblake@redhat.com>
This one is already applied in master.
Fam
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include
2016-06-15 0:33 ` Fam Zheng
@ 2016-06-15 1:41 ` Eric Blake
0 siblings, 0 replies; 4+ messages in thread
From: Eric Blake @ 2016-06-15 1:41 UTC (permalink / raw)
To: Fam Zheng; +Cc: qemu-devel, Paolo Bonzini
[-- Attachment #1: Type: text/plain, Size: 760 bytes --]
On 06/14/2016 06:33 PM, Fam Zheng wrote:
> On Tue, 06/14 16:05, Eric Blake wrote:
>> On 05/31/2016 08:23 PM, Fam Zheng wrote:
>>> The file is only included from the top Makefile. Rename it to reflect
>>> this more obviously.
>>>
>>> Signed-off-by: Fam Zheng <famz@redhat.com>
>>> ---
>>> Makefile | 2 +-
>>> tests/{Makefile => Makefile.include} | 0
>>> 2 files changed, 1 insertion(+), 1 deletion(-)
>>> rename tests/{Makefile => Makefile.include} (100%)
>>
>> Reviewed-by: Eric Blake <eblake@redhat.com>
>
> This one is already applied in master.
>
Oh, shows how much I rely on tab-completion.
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 604 bytes --]
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-06-15 1:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-01 2:23 [Qemu-devel] [PATCH] tests: Rename tests/Makefile to tests/Makefile.include Fam Zheng
2016-06-14 22:05 ` Eric Blake
2016-06-15 0:33 ` Fam Zheng
2016-06-15 1:41 ` Eric Blake
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).