From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:57539)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b7zo9-00049C-J7
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 02:39:14 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b7zo5-0007co-FC
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 02:39:12 -0400
Received: from mx1.redhat.com ([209.132.183.28]:51489)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b7zo5-0007ck-9Q
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 02:39:09 -0400
Message-ID: <1464763147.8823.14.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 01 Jun 2016 08:39:07 +0200
In-Reply-To: <CAFEAcA90u-iDY-6PRiSrOeGLvyDR16S51+K=tn-oBsBqc6zvrQ@mail.gmail.com>
References: <2e555d67b7e53a86bef98f774a2706f2b0ec4ea0.1464728215.git.crobinso@redhat.com>
	<CAFEAcA90u-iDY-6PRiSrOeGLvyDR16S51+K=tn-oBsBqc6zvrQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH] ui: sdl2: Fix crash with -nodefaults -sdl
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Peter Maydell <peter.maydell@linaro.org>
Cc: Cole Robinson <crobinso@redhat.com>, QEMU Developers <qemu-devel@nongnu.org>

On Di, 2016-05-31 at 22:49 +0100, Peter Maydell wrote:
> On 31 May 2016 at 21:56, Cole Robinson <crobinso@redhat.com> wrote:
> > $ ./x86_64-softmmu/qemu-system-x86_64 -nodefaults -sdl
> > Segmentation fault (core dumped)
> >
> > 0  0x00005555559631af in sdl_display_init (ds=3D<optimized out>, full_s=
creen=3D0, no_frame=3D<optimized out>) at ui/sdl2.c:822
> > 1  0x00005555556c8a9a in main (argc=3D<optimized out>, argv=3D<optimize=
d out>, envp=3D<optimized out>) at vl.c:4527
> >
> > Setting the window icon assumes there's always an SDL output window
> > available, which isn't the case with when there's no video device,
> > like via -nodefaults. So don't try to set a window icon when we don't
> > have any outputs.
>=20
> Presumably we also crash for boards like the arm 'virt'
> which just don't have a display device at all...

There are still the vc's for monitor and serial.

cheers,
  Gerd