From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:45552)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b83Zq-0008KW-5Q
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 06:40:43 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <kraxel@redhat.com>) id 1b83Zo-0005F9-7u
	for qemu-devel@nongnu.org; Wed, 01 Jun 2016 06:40:41 -0400
Message-ID: <1464777632.8823.22.camel@redhat.com>
From: Gerd Hoffmann <kraxel@redhat.com>
Date: Wed, 01 Jun 2016 12:40:32 +0200
In-Reply-To: <1464774261-648-3-git-send-email-famz@redhat.com>
References: <1464774261-648-1-git-send-email-famz@redhat.com>
	<1464774261-648-3-git-send-email-famz@redhat.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Mime-Version: 1.0
Subject: Re: [Qemu-devel] [PATCH v3 2/2] Makefile: Derive "PKGVERSION" from
 "git describe" by default
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel/>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Fam Zheng <famz@redhat.com>
Cc: qemu-devel@nongnu.org, peter.maydell@linaro.org, qemu-block@nongnu.org, Paolo Bonzini <pbonzini@redhat.com>, lersek@redhat.com

  Hi,

> +				git describe 2>/dev/null | tr -d '\n'; \
> +				if ! git diff-index --quiet HEAD &>/dev/null; then \
> +					printf -- '-dirty'; \
> +				fi \

/me suggests "git describe --dirty --match 'v*'"

Saves the extra effort to check for a dirty tree manually.

Also greatly reduces the chance non-release tags are matched, so I don't
get results like "pull-vga-20160523-1-236-g9fd5eb7".

cheers,
  Gerd