From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, pbonzini@redhat.com, rth@twiddle.net,
ehabkost@redhat.com, blauwirbel@gmail.com,
mark.cave-ayland@ilande.co.uk, qemu-arm@nongnu.org
Subject: [Qemu-devel] [PATCH RFC 3/8] target-i386: cpu: use cpu_generic_init() in cpu_x86_init()
Date: Wed, 1 Jun 2016 18:37:25 +0200 [thread overview]
Message-ID: <1464799050-11002-4-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1464799050-11002-1-git-send-email-imammedo@redhat.com>
now cpu_x86_init() does nothing more or less
than duplicating cpu_generic_init() logic.
So simplify it by using cpu_generic_init().
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
---
target-i386/cpu.c | 20 +-------------------
1 file changed, 1 insertion(+), 19 deletions(-)
diff --git a/target-i386/cpu.c b/target-i386/cpu.c
index c31afc7..238f69d 100644
--- a/target-i386/cpu.c
+++ b/target-i386/cpu.c
@@ -2240,25 +2240,7 @@ out:
X86CPU *cpu_x86_init(const char *cpu_model)
{
- Error *error = NULL;
- X86CPU *cpu;
-
- cpu = cpu_x86_create(cpu_model, &error);
- if (error) {
- goto out;
- }
-
- object_property_set_bool(OBJECT(cpu), true, "realized", &error);
-
-out:
- if (error) {
- error_report_err(error);
- if (cpu != NULL) {
- object_unref(OBJECT(cpu));
- cpu = NULL;
- }
- }
- return cpu;
+ return X86_CPU(cpu_generic_init(TYPE_X86_CPU, cpu_model));
}
static void x86_cpu_cpudef_class_init(ObjectClass *oc, void *data)
--
1.8.3.1
next prev parent reply other threads:[~2016-06-01 16:37 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-01 16:37 [Qemu-devel] [PATCH RFC 0/8] cpus: make "-cpu cpux, features" global properties Igor Mammedov
2016-06-01 16:37 ` [Qemu-devel] [PATCH RFC 1/8] target-i386: cpu: move features logic that requires CPUState to realize time Igor Mammedov
2016-06-01 17:43 ` Eduardo Habkost
2016-06-02 9:59 ` Igor Mammedov
2016-06-02 14:38 ` Eduardo Habkost
2016-06-02 16:56 ` Igor Mammedov
2016-06-02 17:34 ` Eduardo Habkost
2016-06-02 18:23 ` Igor Mammedov
2016-06-02 18:43 ` Eduardo Habkost
2016-06-03 10:13 ` Igor Mammedov
2016-06-03 19:26 ` Eduardo Habkost
2016-06-04 16:44 ` Igor Mammedov
2016-06-01 16:37 ` [Qemu-devel] [PATCH RFC 2/8] target-i386: cpu: move xcc->kvm_required check to reaize time Igor Mammedov
2016-06-01 17:46 ` Eduardo Habkost
2016-06-02 10:02 ` Igor Mammedov
2016-06-01 16:37 ` Igor Mammedov [this message]
2016-06-01 18:08 ` [Qemu-devel] [PATCH RFC 3/8] target-i386: cpu: use cpu_generic_init() in cpu_x86_init() Eduardo Habkost
2016-06-01 16:37 ` [Qemu-devel] [PATCH RFC 4/8] target-i386: cpu: consolidate calls of object_property_parse() in x86_cpu_parse_featurestr Igor Mammedov
2016-06-01 18:46 ` Eduardo Habkost
2016-06-02 12:22 ` Igor Mammedov
2016-06-02 14:42 ` Eduardo Habkost
2016-06-02 14:53 ` Eduardo Habkost
2016-06-02 15:05 ` Peter Krempa
2016-06-02 16:31 ` Igor Mammedov
2016-06-03 7:30 ` Peter Krempa
2016-06-03 9:37 ` Igor Mammedov
2016-06-03 19:36 ` Eduardo Habkost
2016-06-02 16:32 ` Igor Mammedov
2016-06-02 16:55 ` [Qemu-devel] [PATCH] target-i386: Remove xlevel & hv-spinlocks option fixups Eduardo Habkost
2016-06-02 21:07 ` [Qemu-devel] [libvirt] " Eric Blake
2016-06-01 16:37 ` [Qemu-devel] [PATCH RFC 5/8] target-sparc: cpu: use sparc_cpu_parse_features() directly Igor Mammedov
2016-06-01 16:37 ` [Qemu-devel] [PATCH RFC 6/8] cpu: use CPUClass->parse_features() as convertor to global properties Igor Mammedov
2016-06-01 18:54 ` Eduardo Habkost
2016-06-02 10:06 ` Igor Mammedov
2016-06-02 14:41 ` Eduardo Habkost
2016-06-01 16:37 ` [Qemu-devel] [PATCH RFC 7/8] arm: virt: parse cpu_model only once Igor Mammedov
2016-06-01 16:37 ` [Qemu-devel] [PATCH RFC 8/8] pc: parse cpu features " Igor Mammedov
2016-06-01 18:21 ` [Qemu-devel] [PATCH RFC 0/8] cpus: make "-cpu cpux, features" global properties Peter Maydell
2016-06-01 18:51 ` Eduardo Habkost
2016-06-02 20:44 ` David Hildenbrand
2016-06-03 12:06 ` Jiri Denemark
2016-06-03 12:14 ` David Hildenbrand
[not found] ` <201606022044.u52KaIkv017063@mx0a-001b2d01.pphosted.com>
2016-06-03 0:02 ` Eduardo Habkost
2016-06-03 6:36 ` David Hildenbrand
[not found] ` <20160603083621.6547bde4@thinkpad-w530>
2016-06-03 9:20 ` Igor Mammedov
2016-06-03 10:18 ` David Hildenbrand
2016-06-03 19:54 ` Eduardo Habkost
2016-06-06 9:59 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464799050-11002-4-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=blauwirbel@gmail.com \
--cc=ehabkost@redhat.com \
--cc=mark.cave-ayland@ilande.co.uk \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).