From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:50611) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8j9w-0003q0-KQ for qemu-devel@nongnu.org; Fri, 03 Jun 2016 03:04:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b8j9o-0006NY-5T for qemu-devel@nongnu.org; Fri, 03 Jun 2016 03:04:43 -0400 Received: from mx1.redhat.com ([209.132.183.28]:39343) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b8j9n-0006K6-Vg for qemu-devel@nongnu.org; Fri, 03 Jun 2016 03:04:36 -0400 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 06392C05B1EC for ; Fri, 3 Jun 2016 07:04:34 +0000 (UTC) From: Gerd Hoffmann Date: Fri, 3 Jun 2016 09:04:23 +0200 Message-Id: <1464937468-14816-3-git-send-email-kraxel@redhat.com> In-Reply-To: <1464937468-14816-1-git-send-email-kraxel@redhat.com> References: <1464937468-14816-1-git-send-email-kraxel@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Subject: [Qemu-devel] [PULL 2/7] ui: spice: Exit if gl=on EGL init fails List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: qemu-devel@nongnu.org Cc: Cole Robinson , Gerd Hoffmann From: Cole Robinson The user explicitly requested spice GL, so if we know it isn't going to work we should exit Signed-off-by: Cole Robinson Reviewed-by: Marc-Andr=C3=A9 Lureau Message-id: e3789e35b16f9e3cc6f2652f91c52d88ba6d6936.1463588606.git.crobi= nso@redhat.com Signed-off-by: Gerd Hoffmann --- ui/spice-core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/ui/spice-core.c b/ui/spice-core.c index 61db3c1..da05054 100644 --- a/ui/spice-core.c +++ b/ui/spice-core.c @@ -833,9 +833,11 @@ void qemu_spice_init(void) "incompatible with -spice port/tls-port"); exit(1); } - if (egl_rendernode_init() =3D=3D 0) { - display_opengl =3D 1; + if (egl_rendernode_init() !=3D 0) { + error_report("Failed to initialize EGL render node for SPICE= GL"); + exit(1); } + display_opengl =3D 1; } #endif } --=20 1.8.3.1