From: Gerd Hoffmann <kraxel@redhat.com>
To: qemu-devel@nongnu.org
Cc: Gerd Hoffmann <kraxel@redhat.com>, Paolo Bonzini <pbonzini@redhat.com>
Subject: [Qemu-devel] [PULL 3/7] gtk: fix unchecked vc dereference
Date: Fri, 3 Jun 2016 09:04:24 +0200 [thread overview]
Message-ID: <1464937468-14816-4-git-send-email-kraxel@redhat.com> (raw)
In-Reply-To: <1464937468-14816-1-git-send-email-kraxel@redhat.com>
Spotted by Coverity.
Cc: Paolo Bonzini <pbonzini@redhat.com>
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Message-id: 1463737748-1062-1-git-send-email-kraxel@redhat.com
---
ui/gtk.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/ui/gtk.c b/ui/gtk.c
index 7572cec..01b8216 100644
--- a/ui/gtk.c
+++ b/ui/gtk.c
@@ -1477,13 +1477,14 @@ static void gd_grab_pointer(VirtualConsole *vc, const char *reason)
static void gd_ungrab_pointer(GtkDisplayState *s)
{
VirtualConsole *vc = s->ptr_owner;
- GdkDisplay *display = gtk_widget_get_display(vc->gfx.drawing_area);
+ GdkDisplay *display;
if (vc == NULL) {
return;
}
s->ptr_owner = NULL;
+ display = gtk_widget_get_display(vc->gfx.drawing_area);
#if GTK_CHECK_VERSION(3, 20, 0)
gd_grab_update(vc, vc->s->kbd_owner == vc, false);
gdk_device_warp(gd_get_pointer(display),
--
1.8.3.1
next prev parent reply other threads:[~2016-06-03 7:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-03 7:04 [Qemu-devel] [PULL 0/7] ui patch queue Gerd Hoffmann
2016-06-03 7:04 ` [Qemu-devel] [PULL 1/7] ui: egl: Replace fprintf with error_report Gerd Hoffmann
2016-06-03 7:04 ` [Qemu-devel] [PULL 2/7] ui: spice: Exit if gl=on EGL init fails Gerd Hoffmann
2016-06-03 7:04 ` Gerd Hoffmann [this message]
2016-06-03 7:04 ` [Qemu-devel] [PULL 4/7] SDL2: add bgrx pixel format Gerd Hoffmann
2016-06-03 7:04 ` [Qemu-devel] [PULL 5/7] vnc: Add support for color map Gerd Hoffmann
2016-06-06 8:35 ` Paolo Bonzini
2016-06-03 7:04 ` [Qemu-devel] [PULL 6/7] sdl2: skip init without outputs Gerd Hoffmann
2016-06-03 7:04 ` [Qemu-devel] [PULL 7/7] vnc: add configurable keyboard delay Gerd Hoffmann
2016-06-03 12:04 ` [Qemu-devel] [PULL 0/7] ui patch queue Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1464937468-14816-4-git-send-email-kraxel@redhat.com \
--to=kraxel@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).