* [Qemu-devel] [PATCH] spapr_pci: Drop cannot_instantiate_with_device_add_yet=false
@ 2016-06-03 13:04 Markus Armbruster
2016-06-03 13:28 ` Alexey Kardashevskiy
0 siblings, 1 reply; 3+ messages in thread
From: Markus Armbruster @ 2016-06-03 13:04 UTC (permalink / raw)
To: qemu-devel; +Cc: qemu-ppc, david, agraf, Alexey Kardashevskiy
It's become redundant since it was added in commit 09aa9a5 "spapr-pci:
enable adding PHB via -device".
Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
---
hw/ppc/spapr_pci.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 856aec7..18638dd 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1624,7 +1624,6 @@ static void spapr_phb_class_init(ObjectClass *klass, void *data)
dc->reset = spapr_phb_reset;
dc->vmsd = &vmstate_spapr_pci;
set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
- dc->cannot_instantiate_with_device_add_yet = false;
hp->plug = spapr_phb_hot_plug_child;
hp->unplug = spapr_phb_hot_unplug_child;
}
--
2.5.5
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [Qemu-devel] [PATCH] spapr_pci: Drop cannot_instantiate_with_device_add_yet=false
2016-06-03 13:04 [Qemu-devel] [PATCH] spapr_pci: Drop cannot_instantiate_with_device_add_yet=false Markus Armbruster
@ 2016-06-03 13:28 ` Alexey Kardashevskiy
2016-06-06 1:20 ` David Gibson
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Kardashevskiy @ 2016-06-03 13:28 UTC (permalink / raw)
To: Markus Armbruster, qemu-devel; +Cc: qemu-ppc, david, agraf
On 03/06/16 23:04, Markus Armbruster wrote:
> It's become redundant since it was added in commit 09aa9a5 "spapr-pci:
> enable adding PHB via -device".
>
> Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
> ---
> hw/ppc/spapr_pci.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> index 856aec7..18638dd 100644
> --- a/hw/ppc/spapr_pci.c
> +++ b/hw/ppc/spapr_pci.c
> @@ -1624,7 +1624,6 @@ static void spapr_phb_class_init(ObjectClass *klass, void *data)
> dc->reset = spapr_phb_reset;
> dc->vmsd = &vmstate_spapr_pci;
> set_bit(DEVICE_CATEGORY_BRIDGE, dc->categories);
> - dc->cannot_instantiate_with_device_add_yet = false;
> hp->plug = spapr_phb_hot_plug_child;
> hp->unplug = spapr_phb_hot_unplug_child;
> }
>
--
Alexey
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [Qemu-devel] [PATCH] spapr_pci: Drop cannot_instantiate_with_device_add_yet=false
2016-06-03 13:28 ` Alexey Kardashevskiy
@ 2016-06-06 1:20 ` David Gibson
0 siblings, 0 replies; 3+ messages in thread
From: David Gibson @ 2016-06-06 1:20 UTC (permalink / raw)
To: Alexey Kardashevskiy; +Cc: Markus Armbruster, qemu-devel, qemu-ppc, agraf
[-- Attachment #1: Type: text/plain, Size: 641 bytes --]
On Fri, Jun 03, 2016 at 11:28:08PM +1000, Alexey Kardashevskiy wrote:
> On 03/06/16 23:04, Markus Armbruster wrote:
> > It's become redundant since it was added in commit 09aa9a5 "spapr-pci:
> > enable adding PHB via -device".
> >
> > Cc: Alexey Kardashevskiy <aik@ozlabs.ru>
> > Signed-off-by: Markus Armbruster <armbru@redhat.com>
>
>
>
>
> Reviewed-by: Alexey Kardashevskiy <aik@ozlabs.ru>
Applied to ppc-for-2.7, thanks.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 819 bytes --]
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2016-06-06 1:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-06-03 13:04 [Qemu-devel] [PATCH] spapr_pci: Drop cannot_instantiate_with_device_add_yet=false Markus Armbruster
2016-06-03 13:28 ` Alexey Kardashevskiy
2016-06-06 1:20 ` David Gibson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).