From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56235) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9YEt-0001km-He for qemu-devel@nongnu.org; Sun, 05 Jun 2016 09:37:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1b9YEo-0000LP-De for qemu-devel@nongnu.org; Sun, 05 Jun 2016 09:37:14 -0400 Received: from mga14.intel.com ([192.55.52.115]:63758) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1b9YEo-0000LE-84 for qemu-devel@nongnu.org; Sun, 05 Jun 2016 09:37:10 -0400 Message-ID: <1465132111.14690.15.camel@vmm.sh.intel.com> From: Robert Hu Reply-To: robert.hu@intel.com Date: Sun, 05 Jun 2016 21:08:31 +0800 In-Reply-To: <8cbea5f1-bd87-4321-77e1-620a6c0234ac@redhat.com> References: <1464678190-9290-1-git-send-email-robert.hu@intel.com> <8cbea5f1-bd87-4321-77e1-620a6c0234ac@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Subject: Re: [Qemu-devel] [PATCH 0/2] Reveal 'to' parameter of 'vnc' option to user List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Paolo Bonzini Cc: Robert Ho , qemu-devel@nongnu.org On Tue, 2016-05-31 at 14:59 +0200, Paolo Bonzini wrote: > > On 31/05/2016 09:03, Robert Ho wrote: > > I find that '-vnc' option actually has a parameter 'to', implicitly; > > while actually is there and can be used but not be public. > > Don't know why but this may probably confuse user, especially when used in > > some default situation implicitly. > > > > So shall I? > > 1. Add its description in QEMU manual info > > 2. Expilicitly print out when it's used with non-default value > > I think patch 1 is okay. Thanks Paolo. Sorry for late reply, since I just part-time work on this. > > For patch 2, I am not sure I see the point of printing the VNC options; > the VNC port is printed immediately after. I agree it is not significantly meaningful to print out the options. I just disliked the implicitly be-on-behalf-chose a value without notification; especially we don't know there is a 'to' option. So when I did the density test of huge quantity of guests, always failed on 99th, made me quizzical. :( In most ordinary cases, the final 'VNC server running on ...' printf is sufficient. Now my that emotion gradually die out, I agree abandon patch 2. :) > > However, I think it is useful to print the VNC port whenever the user > specifies "-vnc to=XX". Perhaps you could move show_vnc_port (the > variable, the assignments and the "if (show_vnc_port)") from vl.c to > vnc_display_open? And 2nd reason I abandon patch 2: I grepped in vnc.c, no bare 'printf'. Any nice wrapper for such info purpose? I don't want to be first 'bad guy' to break the elegant code. ;) So do I need to send out v2 patch? which simply contains single patch 1. > > Thanks, > > Paolo