From: "Michael S. Tsirkin" <mst@redhat.com>
To: qemu-devel@nongnu.org
Cc: Peter Maydell <peter.maydell@linaro.org>,
Corey Minyard <cminyard@mvista.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Richard Henderson <rth@twiddle.net>,
Eduardo Habkost <ehabkost@redhat.com>
Subject: [Qemu-devel] [PULL 14/25] pc: Postpone SMBIOS table installation to post machine init
Date: Sun, 5 Jun 2016 16:21:36 +0300 [thread overview]
Message-ID: <1465132825-14242-15-git-send-email-mst@redhat.com> (raw)
In-Reply-To: <1465132825-14242-1-git-send-email-mst@redhat.com>
From: Corey Minyard <cminyard@mvista.com>
This is the same place that the ACPI SSDT table gets added, so that
devices can add themselves to the SMBIOS table.
Signed-off-by: Corey Minyard <cminyard@mvista.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
---
hw/i386/pc.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index e29ccc8..92125a8 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -765,8 +765,6 @@ static FWCfgState *bochs_bios_init(AddressSpace *as, PCMachineState *pcms)
acpi_tables, acpi_tables_len);
fw_cfg_add_i32(fw_cfg, FW_CFG_IRQ0_OVERRIDE, kvm_allows_irq0_override());
- pc_build_smbios(fw_cfg);
-
fw_cfg_add_bytes(fw_cfg, FW_CFG_E820_TABLE,
&e820_reserve, sizeof(e820_reserve));
fw_cfg_add_file(fw_cfg, "etc/e820", e820_table,
@@ -1182,6 +1180,9 @@ void pc_machine_done(Notifier *notifier, void *data)
}
acpi_setup();
+ if (pcms->fw_cfg) {
+ pc_build_smbios(pcms->fw_cfg);
+ }
}
void pc_guest_info_init(PCMachineState *pcms)
--
MST
next prev parent reply other threads:[~2016-06-05 13:21 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 13:20 [Qemu-devel] [PULL 00/25] pc, pci, virtio: new features, cleanups, fixes Michael S. Tsirkin
2016-06-05 13:20 ` [Qemu-devel] [PULL 01/25] tests: acpi: report names of expected files in verbose mode Michael S. Tsirkin
2016-06-05 13:20 ` [Qemu-devel] [PULL 02/25] acpi: add aml_debug() Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 03/25] acpi: add aml_refof() Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 04/25] pc: acpi: remove AML for empty/not used GPE handlers Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 05/25] pc: acpi: consolidate CPU hotplug AML Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 06/25] pc: acpi: consolidate \GPE._E02 with the rest of " Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 07/25] pc: acpi: cpu-hotplug: make AML CPU_foo defines local to cpu_hotplug_acpi_table.c Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 08/25] pc: acpi: mark current CPU hotplug functions as legacy Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 09/25] pc: acpi: consolidate legacy CPU hotplug in one file Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 10/25] pc: acpi: simplify build_legacy_cpu_hotplug_aml() signature Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 11/25] pc: acpi: cpuhp-legacy: switch ProcessorID to possible_cpus idx Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 12/25] tests: acpi: update tables with consolidated legacy cpu-hotplug AML Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 13/25] ipmi: rework the fwinfo to be fetched from the interface Michael S. Tsirkin
2016-06-05 13:21 ` Michael S. Tsirkin [this message]
2016-06-05 13:21 ` [Qemu-devel] [PULL 15/25] acpi: extend ACPI interface to provide send_event hook Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 16/25] pc: use AcpiDeviceIfClass.send_event to issue GPE events Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 17/25] acpi: convert linker from GArray to BIOSLinker structure Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 18/25] acpi: simplify bios_linker API by removing redundant 'table' argument Michael S. Tsirkin
2016-06-06 13:18 ` [Qemu-devel] [PATCH 18/25] fixup! " Igor Mammedov
2016-06-05 13:21 ` [Qemu-devel] [PULL 19/25] acpi: cleanup bios_linker_loader_cleanup() Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 20/25] tpm: apci: cleanup TCPA table initialization Michael S. Tsirkin
2016-06-05 13:21 ` [Qemu-devel] [PULL 21/25] acpi: make bios_linker_loader_add_pointer() API offset based Michael S. Tsirkin
2016-06-06 13:20 ` [Qemu-devel] [PATCH 21/25] fixup! " Igor Mammedov
2016-06-05 13:22 ` [Qemu-devel] [PULL 22/25] acpi: make bios_linker_loader_add_checksum() " Michael S. Tsirkin
2016-06-05 13:22 ` [Qemu-devel] [PULL 23/25] pc-dimm: get memory region from ->get_memory_region() Michael S. Tsirkin
2016-06-05 13:22 ` [Qemu-devel] [PULL 24/25] pc-dimm: introduce realize callback Michael S. Tsirkin
2016-06-05 13:22 ` [Qemu-devel] [PULL 25/25] virtio: move bi-endian target support to a single location Michael S. Tsirkin
2016-06-06 10:14 ` [Qemu-devel] [PULL 00/25] pc, pci, virtio: new features, cleanups, fixes Peter Maydell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465132825-14242-15-git-send-email-mst@redhat.com \
--to=mst@redhat.com \
--cc=cminyard@mvista.com \
--cc=ehabkost@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
--cc=rth@twiddle.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).