From: David Kiarie <davidkiarie4@gmail.com>
To: qemu-devel@nongnu.org
Cc: imammedo@redhat.com, ehabkost@redhat.com, jasowang@redhat.com,
marcel@redhat.com, mst@redhat.com, pbonzini@redhat.com,
jan.kiszka@web.de, rkrcmar@redhat.com,
alex.williamson@redhat.com, wexu@redhat.com,
valentine.sinitsyn@gmail.com, peterx@redhat.com,
David Kiarie <davidkiarie4@gmail.com>
Subject: [Qemu-devel] [RFC] AMD IOMMU: emulate multiple devices
Date: Sun, 5 Jun 2016 19:54:32 +0300 [thread overview]
Message-ID: <1465145673-5315-1-git-send-email-davidkiarie4@gmail.com> (raw)
Hello all,
This patch tries to solve a problem whereby real AMD IOMMUs exhibit both PCI and Platform device properties. AMD IOMMU properties that conflict with conventional PCI devices' features include the fact that its not a BusMaster device, reserves MMIO region without a BAR register.
There is some already ongoing work on Intel IOMMU Interrupt remapping with implements an IOMMU base class, as a platform device(which means the moment I inherit from this class my device loses it's PCI properties). I am therefore forced to find a way to combine both PCI and platform features(which I had previously avoided) into AMD IOMMU.
This patch implements a dummy PCI device which serves to 'steal' PCI config space while the rest of the device remains a platform device. The platform device maintains a reference to the PCI and hence the relevant PCI config space. Please ignore details in this patch and review the design. Also, some of the changes here are not related to the above issue.
Looking forward to your comments!
David Kiarie (1):
Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties.
hw/acpi/aml-build.c | 2 +-
hw/i386/amd_iommu.c | 1471 +++++++++++++++++++++++++++++++++++++++++++
hw/i386/amd_iommu.h | 348 ++++++++++
hw/i386/kvm/pci-assign.c | 2 +-
hw/i386/pc_q35.c | 1 +
include/hw/acpi/acpi-defs.h | 13 +
include/hw/acpi/aml-build.h | 1 +
include/hw/pci/pci.h | 10 +-
qemu-options.hx | 7 +-
util/qemu-config.c | 8 +-
10 files changed, 1853 insertions(+), 10 deletions(-)
create mode 100644 hw/i386/amd_iommu.c
create mode 100644 hw/i386/amd_iommu.h
--
2.1.4
next reply other threads:[~2016-06-05 16:54 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-05 16:54 David Kiarie [this message]
2016-06-05 16:54 ` [Qemu-devel] [RFC] Allow AMD IOMMU to have both SysBusDevice and PCIDevice properties David Kiarie
2016-06-07 19:12 ` Eduardo Habkost
2016-06-07 19:32 ` David Kiarie
2016-06-08 2:17 ` Peter Xu
2016-06-09 13:23 ` Marcel Apfelbaum
2016-06-11 12:01 ` David Kiarie
-- strict thread matches above, loose matches on Subject: below --
2016-06-08 10:00 [Qemu-devel] [RFC] AMD IOMMU: emulate multiple devices David Kiarie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1465145673-5315-1-git-send-email-davidkiarie4@gmail.com \
--to=davidkiarie4@gmail.com \
--cc=alex.williamson@redhat.com \
--cc=ehabkost@redhat.com \
--cc=imammedo@redhat.com \
--cc=jan.kiszka@web.de \
--cc=jasowang@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=peterx@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=rkrcmar@redhat.com \
--cc=valentine.sinitsyn@gmail.com \
--cc=wexu@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).